🔄Switch from yarn to npm#912
Conversation
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
soumeh01
force-pushed
the
yarn-to-npm
branch
3 times, most recently
from
a805578 to
99f057a
Compare
soumeh01
added
the
Developer Efficiency
soumeh01
left a comment
soumeh01
left a comment
There was a problem hiding this comment.
@jreineckearm I couldn’t find any references to scripts/update-tpip.ts in the repo, just wanted to check whether it is still needed. Is this something that is meant to be run manually to update TPIP and push those changes?
Currently, it is removed in this PR, but if it is still required, I am happy to adapt it to work with npm dependencies.
|
I wasn't even aware anymore of this script being present. I normally update package.json manually and use yarn/npm to update dependencies in the lockfile. Or dependabot. |
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
See first feedback, will try locally in the morning and check the lock files. But thinking about it, it may be less effort to take the hit of losing patched dependencies and let dependabot do its magic to fix them again.
| @@ -0,0 +1,2 @@ | |||
| @open-cmsis-pack:registry=https://npm.pkg.github.com | |||
There was a problem hiding this comment.
👍 Thanks for remembering to add the rc file
| QUALIFIER=$(git describe --tags | grep -Eo '\-g[0-9a-f]+$' || true) | ||
| yarn version -s --no-git-tag-version --new-version "${DESCRIBE#v}" | ||
| yarn version --no-git-tag-version --prepatch --preid "pr${{ github.event.number }}${QUALIFIER}" | ||
| npm version -s --allow-same-version --no-git-tag-version --new-version "${BASE_TAG#v}" |
There was a problem hiding this comment.
May need another review. Can't see PR number, nor commit hash on build artifact names (neither zip, nor vsix).
|
somehow got polluted while rebasing |
2 participants
yarntonpm, updating docs, code references, dependencies, scripts, and GitHub workflows.Checklist