Skip to content

ComponentViewer: Adapted peripheral inspector interrupt table#913

Merged
thorstendb-ARM merged 25 commits into
mainfrom
showInterruptNames
Mar 26, 2026
Merged

ComponentViewer: Adapted peripheral inspector interrupt table#913
thorstendb-ARM merged 25 commits into
mainfrom
showInterruptNames

Conversation

@thorstendb-ARM
Copy link
Copy Markdown
Collaborator

Changes

  • uses interface to Peripheral Inspector to fetch interrupt names from interrupt numbers

Ref

Screenshots

image

Example:

        <item property="Vector Handlers" value="">
          <list name="Count" start="0" limit="Vectors.INTLINESNUM*32">
          <calc>
            irqPresent = Vectors.Displayed[Count]==1;
            irqCore = Count&lt;16;
            irqExt = Count&gt;15;
          </calc>

            <item cond="irqPresent" value="">
              <print property="%E[Vectors.Index[Count]]" value="%d[Count]" cond="irqCore"/>
              <print property="%Q[Count] (EXTIRQ%d[Count-16])" value="" cond="irqExt"/>
              <item property="Index" value="%d[Vectors.Index[Count]]"/>
              <item property="Enable" value="%d[Vectors.Enable[Count]]"/>
              <item property="Pending" value="%d[Vectors.Pending[Count]]"/>
              <item property="Active" value="%d[Vectors.Active[Count]]"/>
              <item property="Priority" value="%d[Vectors.Priority[Count]]"/>
            </item>
         </list>
        </item>

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@thorstendb-ARM
Copy link
Copy Markdown
Collaborator Author

thorstendb-ARM commented Mar 18, 2026

This build fails intentionally due to the copyright notice in the temporarily included API header.

…changes)

Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 19, 2026

All good ✅

Comment thread yarn.lock Outdated
@jreineckearm
Copy link
Copy Markdown
Collaborator

Updated to use the entire Peripheral Inspector repo as node_module. Still not ideal due to the new (and partly vulnerable) dependencies. But better than copying over code from the other repo/project. Will try to fix the final CVE in peripheral inspector next week before release. Needs a major version update of another dependency (pulling in the offending one) there.

Note: while testing, I didn't see the interrupt names. I can't see the NVIC SCVD being updated in this PR.

Rest of the code changes look good.

Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 19, 2026

Qlty

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on main by 0.03%.

Modified Files with Diff Coverage (5)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/views/component-viewer/component-viewer-base.ts66.7%280
Coverage rating: A Coverage rating: A
src/views/component-viewer/scvd-eval-interface.ts100.0%
Coverage rating: A Coverage rating: A
src/views/component-viewer/component-viewer-instance.ts0.0%62
Coverage rating: A Coverage rating: A
src/views/component-viewer/scvd-eval-context.ts75.0%135
New file Coverage rating: A
src/views/component-viewer/data-host/interrupt-host.ts100.0%
Total92.9%
🤖 Increase coverage with AI coding...

In the `showInterruptNames` branch, add test coverage for this new code:

- `src/views/component-viewer/component-viewer-base.ts` -- Line 280
- `src/views/component-viewer/component-viewer-instance.ts` -- Line 62
- `src/views/component-viewer/scvd-eval-context.ts` -- Line 135

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested to full extent. Does it make sense to update the SCVD file in the PR? Would make testers' lives easier.

Comment thread src/views/component-viewer/data-host/interrupt-host.ts Outdated
Comment thread src/views/component-viewer/test/unit/memory-host/interrupt-host.test.ts Outdated
@thorstendb-ARM thorstendb-ARM marked this pull request as ready for review March 23, 2026 12:45
to check if depedency reviewer is happy now

Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
jreineckearm
jreineckearm previously approved these changes Mar 25, 2026
Copy link
Copy Markdown
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and work nicely with and without just published Peripheral Inspector v1.9.0, as well as with previous v1.8.x releases without extension API updates.

Good to merge.

Comment thread src/views/component-viewer/data-host/interrupt-host.ts Outdated
JonatanAntoni
JonatanAntoni previously approved these changes Mar 25, 2026
Comment thread src/views/component-viewer/data-host/interrupt-host.ts Outdated
Comment thread src/views/component-viewer/data-host/interrupt-host.ts Outdated
Copy link
Copy Markdown
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback, good to get merged.

@thorstendb-ARM thorstendb-ARM merged commit b0e4cc7 into main Mar 26, 2026
20 checks passed
@thorstendb-ARM thorstendb-ARM deleted the showInterruptNames branch March 26, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants