Skip to content

Fix insecure URL scan and standardize APIs#924

Merged
jreineckearm merged 4 commits into
mainfrom
link-check
Mar 24, 2026
Merged

Fix insecure URL scan and standardize APIs#924
jreineckearm merged 4 commits into
mainfrom
link-check

Conversation

@soumeh01
Copy link
Copy Markdown
Collaborator

@soumeh01 soumeh01 commented Mar 24, 2026

Fixes:

Changes

  • Fix link checker flag from checkFilesHttp to checkHttp, so HTTP scan actually runs
  • check-link.ts cleaned by standardizing APIs by using one promisified pattern for both file and process APIs
  • Include a link-checking job in the nightly run so we are alerted if any links change or become unreachable.
  • Updated a non-reachable URL in README

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@soumeh01 soumeh01 marked this pull request as ready for review March 24, 2026 09:21
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 24, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@soumeh01 soumeh01 requested a review from jreineckearm March 24, 2026 09:35
@soumeh01 soumeh01 added the Developer Efficiency CI/CD infrastructure and development process improvements label Mar 24, 2026
Copy link
Copy Markdown
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, was briefly questioning why to run them in nightly builds. But then I saw the two README updates where presumably URLs have changed in the docs.

@jreineckearm jreineckearm merged commit 5a1ac78 into main Mar 24, 2026
22 checks passed
@jreineckearm jreineckearm deleted the link-check branch March 24, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Developer Efficiency CI/CD infrastructure and development process improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants