Skip to content

ComponentViewer: Allow expanding filtered items#937

Merged
jreineckearm merged 7 commits into
mainfrom
expandFoundChildren
Mar 31, 2026
Merged

ComponentViewer: Allow expanding filtered items#937
jreineckearm merged 7 commits into
mainfrom
expandFoundChildren

Conversation

@thorstendb-ARM
Copy link
Copy Markdown
Collaborator

Changes

When filtering the Tree with a search string, now the found items can be fully expanded with no filters applyed

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 27, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.04%.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/views/component-viewer/component-viewer-base.ts100.0%
Coverage rating: A Coverage rating: A
src/views/component-viewer/component-viewer-tree-view.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@jreineckearm
Copy link
Copy Markdown
Collaborator

I don't fully understand the filter + expand behavior. I do see some improvement. But I also see for example this:
image

ENABLE of MPU Control has siblings which are not shown.
Enable of Non Maskable Interrupt has siblings which are shown.

Copy link
Copy Markdown
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the offline feedback!
Sugar on top in another PR would be to preserve selections made while filter is active to use it as a navigation means (search something through a filter, then select the point of interest for full info after filter clear).
Good to go with this change now.

@jreineckearm jreineckearm merged commit 386e16b into main Mar 31, 2026
20 checks passed
@jreineckearm jreineckearm deleted the expandFoundChildren branch March 31, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants