Address copilot suggestions

Author: edriouk

src/solutions/solution-converter.ts

@@ -141,6 +141,8 @@ export class SolutionConverterImpl implements SolutionConverter {
 
         let detection = false;
         let convertResult: rpc.ConvertSolutionResult = { success: false };
+        let availableCompilers: string[] = [];
+        let availableConfigurations: rpc.VariablesConfiguration[] | undefined;
         if (!missingPacksResult || missingPacksResult.success) {
             // rpc method: ConvertSolution
             outputChannel.append('Convert solution... ');
@@ -158,20 +160,15 @@ export class SolutionConverterImpl implements SolutionConverter {
             }
 
             // compilers and variables detection: gather locally and emit configure event
-            const availableCompilers = convertResult.selectCompiler ?? [];
+            availableCompilers = convertResult.selectCompiler ?? [];
             detection = availableCompilers.length > 0;
-            let availableConfigurations: rpc.VariablesConfiguration[] | undefined;
             if (convertResult.undefinedLayers) {
                 const result = await this.checkDiscoverLayers();
                 const discoverLayersOutput = !result.success && result.message ? [`error csolution: ${result.message.trim()}`] : [];
                 toolsOutputMessages = toolsOutputMessages.concat(discoverLayersOutput);
                 availableConfigurations = result.configurations;
                 detection = detection || result.success;
             }
-            if (detection) {
-                // compilers and variables detection handling: apply select-compiler and discover layer configurations if any
-                this.eventHub.fireConfigureSolutionDataReady({ availableCompilers, availableConfigurations });
-            }
         }
 
         let logResult = undefined;
@@ -216,6 +213,10 @@ export class SolutionConverterImpl implements SolutionConverter {
             logMessages: logResult,
             toolsOutputMessages,
         });
+        // compilers and variables detection handling:
+        // apply select-compiler and discover layer configurations, reset state otherwise
+        this.eventHub.fireConfigureSolutionDataReady({ availableCompilers, availableConfigurations });
+
     }
 
     private async printErrorsWarnings(messages?: rpc.LogMessages): Promise<void> {

src/views/manage-layers/manage-layers-webview-main.ts

@@ -100,7 +100,6 @@ export class ManageLayersWebviewMain {
         this.webviewManager.sendMessage({ type: 'PLATFORM', data: { name: 'vscode' } });
     }
 
-
     private async applyOrChangeLayer(layer: TargetConfiguration) {
         const csolution = this.solutionManager.getCsolution();
 
@@ -130,6 +129,7 @@ export class ManageLayersWebviewMain {
                     }
                 }
             });
+            this.latestConfigureData = undefined;
             await copyLayerToProject(layer, csolution.solutionDir); // first copy layer files
             await csolution.csolutionYml.save(); // then save csolution.yml
         }
@@ -170,16 +170,19 @@ export class ManageLayersWebviewMain {
     }
 
     private onConfigureSolutionDataReady(data: ConfigureSolutionData): void {
-        this.latestConfigureData = data;
-        this.getDataUserChoice();
+        if (data.availableCompilers.length === 0 && !data.availableConfigurations) {
+            this.latestConfigureData = undefined;
+        } else {
+
+            this.latestConfigureData = data;
+            this.getDataUserChoice();
+        }
     }
 
     private showPanel(show: boolean) {
-        if (!show) {
-            return;
+        if (show) {
+            this.webviewManager.createOrShowPanel();
         }
-
-        this.webviewManager.createOrShowPanel();
     }
 
     private sendConfigurations(configurations: VariablesConfiguration[] | undefined, activeTarget: string, avComps: string[]) {