Skip to content

Commit 2d327b7

Browse files
authored
Migrated from markdown-lint-checker to lychee action (#209)
* Migrated from markdown-lint-checker to lychee action * Migrated from markdown-lint-checker to lychee action * Added lychee configs * Fixed broken links * Added json for local usage back
1 parent b09847c commit 2d327b7

8 files changed

Lines changed: 61 additions & 19 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## Fixes
22
<!-- List the GitHub issue this PR resolves -->
3-
- [#<issue-number>](https://github.com/Open-CMSIS-Pack/vscode-cmsis-solution/issues/<issue-number>)
3+
- #<issue-number> (for example: #123)
44

55
## Changes
66
<!-- List the changes this PR introduces -->

.github/lychee.toml

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
# For all options, see <https://lychee.cli.rs/usage/config/>
2+
3+
# Verbose program output
4+
# Accepts log level: "error", "warn", "info", "debug", "trace"
5+
verbose = "info"
6+
7+
# Interactive progress bar while checking links.
8+
# Disabled for CI usage
9+
no_progress = true
10+
11+
# Enable link caching. This can be helpful to avoid checking the same links on
12+
# multiple runs.
13+
cache = true
14+
15+
accept = [
16+
"200"
17+
]
18+
19+
# Maximum number of allowed redirects.
20+
max_redirects = 2
21+
22+
# Maximum number of allowed retries before a link is declared dead.
23+
max_retries = 2
24+
25+
# Only test links with the given schemes
26+
# Omit to check links with any other scheme.
27+
scheme = ["http", "https", "file"]
28+
29+
# Exclude links
30+
exclude = [
31+
# Exclude links as cookies needed to be accepted
32+
'https://developer.arm.com',
33+
'https://www.st.com/en/development-tools'
34+
]
35+
36+
# Exclude paths from getting checked. The values are treated as regular expressions
37+
exclude_path = [
38+
"(^|[\\\\/])CHANGELOG\\.md$", # skip changelog file
39+
"\\.txt$", # skip .txt extensions
40+
"\\.html$", # skip .html extensions
41+
"test-data/", # skip directories named "test",
42+
"test-results/", # skip directories named "test",
43+
"test-workspace/", # skip directories named "test"
44+
]

.github/workflows/markdown.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ jobs:
7878
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
7979

8080
- name: Check Links
81-
uses: tcort/github-action-markdown-link-check@e7c7a18363c842693fadde5d41a3bd3573a7a225 # v1.1.2
81+
uses: lycheeverse/lychee-action@8646ba30535128ac92d33dfc9133794bfdd9b411 # v2.8.0
8282
with:
83-
use-quiet-mode: 'no'
84-
use-verbose-mode: 'yes'
85-
config-file: '.github/markdown-link-check.jsonc'
83+
args: --config .github/lychee.toml './**/*.md'
84+
fail: true
85+
jobSummary: true

.github/workflows/nightly.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ jobs:
3434
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
3535

3636
- name: Validate Links
37-
uses: tcort/github-action-markdown-link-check@e7c7a18363c842693fadde5d41a3bd3573a7a225 # v1.1.2
37+
uses: lycheeverse/lychee-action@8646ba30535128ac92d33dfc9133794bfdd9b411 # v2.8.0
3838
with:
39-
use-quiet-mode: 'no'
40-
use-verbose-mode: 'yes'
41-
config-file: '.github/markdown-link-check.jsonc'
39+
args: --config .github/lychee.toml './**/*.md'
40+
fail: true
41+
jobSummary: true
4242

4343
build:
4444
if: github.repository == 'Open-CMSIS-Pack/vscode-cmsis-solution'

DEVELOPMENT.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,15 +111,13 @@ Before running a release, check the following:
111111

112112
`<version>` must match a [project manager schemas tag](https://github.com/Open-CMSIS-Pack/devtools/releases)
113113

114-
2. User guide is up-to-date at [MDK-Packs/vscode-cmsis-solution-docs@main](https://github.com/MDK-Packs/vscode-cmsis-solution-docs/tree/main/site).
114+
2. User guide is up-to-date at [MDK-Packs/vscode-cmsis-solution-docs@main](https://github.com/MDK-Packs/vscode-cmsis-solution-docs/tree/main/docs).
115115

116116
3. Update and review [CHANGELOG.md](CHANGELOG.md)
117117

118118
Add all changes relevant for the upcoming release into the `[Unreleased]` section. This section
119119
is automatically replaced by the release version during the release workflow.
120120

121-
4. [Release Assessment](https://armh.sharepoint.com/sites/pwa/PJ1000480/SitePages/Assessments.aspx) for `CMSIS Solution Extension` is approved.
122-
123121
## Release versioning
124122

125123
This repository follows the VS Code Marketplace pre-release recommendation:
@@ -172,7 +170,7 @@ When a new RPC method or data type is needed:
172170
3. **Implement the server side** in [`ProjMgrRpcServer.cpp`](https://github.com/Open-CMSIS-Pack/devtools/blob/main/tools/projmgr/src/ProjMgrRpcServer.cpp) in the `devtools` repository.
173171

174172
4. **Implement the client side** in this extension:
175-
- Copy the regenerated `rpc-interface.ts` into [src/json-rpc/interface/](src/json-rpc/interface/) and update [version.txt](src/json-rpc/interface/version.txt) to the new API version.
173+
- Copy the regenerated `rpc-interface.ts` into `src/json-rpc/interface/` and update `src/json-rpc/interface/version.txt` to the new API version.
176174
- Expose the new method via `CsolutionService` in [src/json-rpc/csolution-rpc-client.ts](src/json-rpc/csolution-rpc-client.ts).
177175
- Use the method from the relevant data source or manager in [src/data-manager/](src/data-manager/).
178176

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Arm CMSIS Solution provides the following views:
2222
- [Manage Solution view](#manage-solution-view): Manage your solutions with multiple targets, projects, and build types to define the scope of your applications.
2323
- [Software Components view](#software-components-view): Access reusable building blocks that are provided in software packs.
2424

25-
[Settings](https://mdk-packs.github.io/vscode-cmsis-solution-docs/configuration.html#configure-the-extension): Configure features like pack download, [clangd](https://marketplace.visualstudio.com/items?itemName=llvm-vs-code-extensions.vscode-clangd), or usage of web services. When **Use Web Services** is enabled, Arm CMSIS Solution gets from [keil.arm.com](https://www.keil.arm.com/packs/) information about devices, boards, and examples that are provided in software packs.
25+
[Settings](https://mdk-packs.github.io/vscode-cmsis-solution-docs/installation.html#configure-the-extension): Configure features like pack download, [clangd](https://marketplace.visualstudio.com/items?itemName=llvm-vs-code-extensions.vscode-clangd), or usage of web services. When **Use Web Services** is enabled, Arm CMSIS Solution gets from [keil.arm.com](https://www.keil.arm.com/packs/) information about devices, boards, and examples that are provided in software packs.
2626

2727
Arm CMSIS Solution works as a standalone tool and can also interact with other VS Code extensions:
2828

@@ -114,9 +114,9 @@ The YML syntax support in the editor detects errors, provides auto completion, a
114114

115115
## Run and Debug
116116

117-
Arm CMSIS Solution generates the [Run and Debug configuration](https://mdk-packs.github.io/vscode-cmsis-solution-docs/conf_debug.html) files including files `.vscode/launch.json` and `.vscode/tasks.json` for the [Arm CMSIS Debugger](https://marketplace.visualstudio.com/items?itemName=Arm.vscode-cmsis-debugger) and various debug adapters (such as CMSIS-DAP, ULINK, JLink, and ST-Link). The [Manage Solution view](#manage-solution-view) simplifies the setup and supports single-core and multi-core configurations.
117+
Arm CMSIS Solution generates the [Run and Debug configuration](https://mdk-packs.github.io/vscode-cmsis-solution-docs/debug.html#configure-run-and-debug) files including files `.vscode/launch.json` and `.vscode/tasks.json` for the [Arm CMSIS Debugger](https://marketplace.visualstudio.com/items?itemName=Arm.vscode-cmsis-debugger) and various debug adapters (such as CMSIS-DAP, ULINK, JLink, and ST-Link). The [Manage Solution view](#manage-solution-view) simplifies the setup and supports single-core and multi-core configurations.
118118

119-
The [Run and Debug configuration](https://mdk-packs.github.io/vscode-cmsis-solution-docs/configuration.html#configure-run-and-debug) is stored in the `csolution.yml` file under `target-set:` as shown below:
119+
The [Run and Debug configuration](https://mdk-packs.github.io/vscode-cmsis-solution-docs/debug.html#configure-run-and-debug) is stored in the `csolution.yml` file under `target-set:` as shown below:
120120

121121
```yml
122122
target-types:

docs/third-party-licenses.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Report prepared at: 03/03/2026, 10:51:48
1313
|@vscode/codicons|0.0.44|https://github.com/microsoft/vscode-codicons|https://github.com/microsoft/vscode-codicons/blob/main/LICENSE|
1414
|@vscode/webview-ui-toolkit|1.4.0|https://github.com/microsoft/vscode-webview-ui-toolkit|https://github.com/microsoft/vscode-webview-ui-toolkit/blob/main/LICENSE|
1515
|antd|5.29.3|https://ant.design|https://github.com/ant-design/ant-design/blob/master/LICENSE|
16-
|async-mutex|0.5.0|https://https://github.com/DirtyHairy/async-mutex|https://github.com/DirtyHairy/async-mutex/blob/master/LICENSE|
16+
|async-mutex|0.5.0|https://github.com/DirtyHairy/async-mutex|https://github.com/DirtyHairy/async-mutex/blob/master/LICENSE|
1717
|eta|4.5.1|https://github.com/eta-dev/eta|https://github.com/eta-dev/eta/blob/main/LICENSE|
1818
|fetch-blob|4.0.0|https://github.com/node-fetch/fetch-blob|https://github.com/node-fetch/fetch-blob/blob/main/LICENSE|
1919
|formdata-polyfill|4.0.10|https://github.com/jimmywarting/FormData|https://github.com/jimmywarting/FormData/blob/master/LICENSE|

src/ARCHITECTURE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@ The Solution Outline docks into the left panel presenting a tree view for the se
2727

2828
The Create Solution dialog shall present boards, devices, and draft projects to the user. The draft project shall be used to initialize a new solution workspace.
2929

30-
[TO BE DOCUMENTED](views/create-solution)
30+
[TO BE DOCUMENTED](views/create-solutions)
3131

3232
### Configure Solution
3333

3434
[TO BE DOCUMENTED](views/manage-layers)
3535

3636
### Context Selection
3737

38-
[TO BE DOCUMENTED](views/context-selection)
38+
[TO BE DOCUMENTED](views/manage-solution)
3939

4040
### Manage Components
4141

0 commit comments

Comments
 (0)