Feature/debug adapter file selection improvements (#60)

* Enhance debug adapter file selection with improved path handling and UI updates

* Fix formatting in openFile button click handler for consistency

* Improve file opening tests with normalized URI path validation

* Fix copyright year and enhance file selection handling in tests

* Improve file selection handling by replacing targetElementId with requestId in SELECT_FILE messages

* Enhance file handling and improve accessibility in Manage Solution components

Author: arneschmid

src/desktop/extension.ts

@@ -224,6 +224,7 @@ export const activate = async (context: ExtensionContext): Promise<CsolutionExte
         commandsProvider,
         configurationProvider,
         csolutionService,
+        externalFileOpener,
     );
     context.subscriptions.push(window.registerCustomEditorProvider(
         ManageSolutionCustomEditorProvider.viewType,

src/views/common/components/cmsis-codicon.tsx

@@ -24,29 +24,35 @@ const CMSIS_CODICON_CODEPOINTS = {
 
 export type CmsisCodiconName = keyof typeof CMSIS_CODICON_CODEPOINTS;
 
-type Props = {
-    name: CmsisCodiconName;
-    title?: string;
-    className?: string;
-    style?: React.CSSProperties;
+type Props = React.ComponentPropsWithoutRef<'span'> & {
+    name: CmsisCodiconName | string;
     fontFamily?: string; // default is your custom webview font
 };
 
 export const CmsisCodicon: React.FC<Props> = ({
     name,
-    title,
     className,
     style,
     fontFamily = 'cmsis-codicon',
+    ...spanProps
 }) => {
-    const codepoint = CMSIS_CODICON_CODEPOINTS[name];
+    const codepoint = CMSIS_CODICON_CODEPOINTS[name as CmsisCodiconName];
+    if (codepoint !== undefined) {
+        return (
+            <span
+                {...spanProps}
+                className={className ?? ''}
+                style={{ fontFamily, display: 'inline-block', lineHeight: 1, ...style }}
+            >
+                {String.fromCodePoint(codepoint)}
+            </span>
+        );
+    }
     return (
         <span
-            title={title}
-            className={className}
-            style={{ fontFamily, display: 'inline-block', lineHeight: 1, ...style }}
-        >
-            {String.fromCodePoint(codepoint)}
-        </span>
+            {...spanProps}
+            className={`codicon codicon-${name}${className ? ` ${className}` : ''}`}
+            style={{ display: 'inline-block', lineHeight: 1, ...style }}
+        />
     );
 };

src/views/manage-solution/manage-solution-custom-editor.ts

@@ -26,6 +26,7 @@ import { ConfigurationProvider } from '../../vscode-api/configuration-provider';
 import { CsolutionService } from '../../json-rpc/csolution-rpc-client';
 import { SolutionData } from './view/state/manage-solution-state';
 import { COMMAND_OPEN_SOLUTION } from '../../solutions/active-solution-tracker';
+import { IOpenFileExternal } from '../../open-file-external-if';
 
 type EditEntry = {
     label: string;
@@ -118,6 +119,7 @@ export class ManageSolutionCustomEditorProvider implements vscode.CustomEditorPr
         private readonly commandsProvider: CommandsProvider,
         private readonly configurationProvider: ConfigurationProvider,
         private readonly csolutionService: CsolutionService,
+        private readonly openFileExternal: IOpenFileExternal,
     ) { }
 
     private getOrCreateWebviewMain(): ManageSolutionWebviewMain {
@@ -134,6 +136,7 @@ export class ManageSolutionCustomEditorProvider implements vscode.CustomEditorPr
                 this.context,
                 this.solutionManager,
                 this.commandsProvider,
+                this.openFileExternal,
                 this.configurationProvider,
                 this.csolutionService,
                 (label, before, after) => this.activeDocument?.recordEdit(label, before, after),

src/views/manage-solution/manage-solution-webview-main.factories.ts

@@ -25,6 +25,8 @@ import { solutionManagerFactory } from '../../solutions/solution-manager.factori
 import { DataManager } from '../../data-manager/data-manager';
 import { DebugAdaptersYamlFile } from '../../debug/debug-adapters-yaml-file';
 import { configurationProviderFactory } from '../../vscode-api/configuration-provider.factories';
+import { IOpenFileExternal } from '../../open-file-external-if';
+import { openFileExternalFactory } from '../../open-file-external.factories';
 import { ETextFileResult } from '../../generic/text-file';
 import { SolutionData } from './view/state/manage-solution-state';
 import { ManageSolutionController } from './manage-solution-controller';
@@ -36,6 +38,7 @@ export type ManageSolutionWebviewMainFactoryOptions = {
     commandsProvider?: MockCommandsProvider;
     dataManager?: DataManager;
     debugAdaptersYmlFile?: DebugAdaptersYamlFile;
+    openFileExternal?: IOpenFileExternal;
     configurationProvider?: ReturnType<typeof configurationProviderFactory>;
     csolutionService?: CsolutionService,
     onEdit?: (label: string, before: SolutionData, after: SolutionData) => void,
@@ -76,6 +79,7 @@ export function manageSolutionWebviewMainFactory(options?: ManageSolutionWebview
         { subscriptions: [] } as unknown as vscode.ExtensionContext,
         options?.solutionManager ?? solutionManagerFactory(),
         options?.commandsProvider ?? commandsProviderFactory(),
+        options?.openFileExternal ?? openFileExternalFactory(),
         options?.configurationProvider ?? configurationProviderFactory(),
         options?.csolutionService ?? jest.mocked<CsolutionService>({
             getDeviceList: async function (_args: GetDeviceListParams): Promise<DeviceList> { throw new Error('Function not implemented.'); },