Rename sendContextData to sendContextDataFromControllerState for clarity and update references in tests

Author: arneschmid

src/views/manage-solution/manage-solution-webview-main.test.ts

@@ -259,7 +259,7 @@ describe('ContextSelectionWebviewMain', () => {
                 callOrder.push('loadSolution');
                 return ETextFileResult.Success;
             });
-            const sendContextDataSpy = jest.spyOn(main as any, 'sendContextData').mockResolvedValue(undefined);
+            const sendContextDataFromControllerStateSpy = jest.spyOn(main as any, 'sendContextDataFromControllerState').mockResolvedValue(undefined);
 
             const hasExternalFileChangesSpy = jest.spyOn(main.controller, 'hasExternalFileChanges').mockImplementation(() => {
                 callOrder.push('hasExternalFileChanges');
@@ -284,19 +284,19 @@ describe('ContextSelectionWebviewMain', () => {
                 'loadSolution',
                 'ensureActiveTargetTypeName',
             ]);
-            expect(sendContextDataSpy).toHaveBeenCalledTimes(1);
+            expect(sendContextDataFromControllerStateSpy).toHaveBeenCalledTimes(1);
         });
 
-        it('calls sendContextData when transitioning to active state', async () => {
+        it('calls sendContextDataFromControllerState when transitioning to active state', async () => {
             const solutionManager = solutionManagerFactory();
             const main = manageSolutionWebviewMainFactory({
                 solutionManager,
                 webviewManager
             });
             (main as any).webviewManager.isPanelActive = jest.fn().mockReturnValue(true); // Simulate active panel
 
-            // Spy on sendContextData to verify it gets called
-            const sendContextDataSpy = jest.spyOn(main as any, 'sendContextData').mockResolvedValue(undefined);
+            // Spy on broadcast helper to verify it gets called
+            const sendContextDataFromControllerStateSpy = jest.spyOn(main as any, 'sendContextDataFromControllerState').mockResolvedValue(undefined);
 
             await main.activate(context as vscode.ExtensionContext);
 
@@ -307,19 +307,19 @@ describe('ContextSelectionWebviewMain', () => {
 
             await waitTimeout();
 
-            expect(sendContextDataSpy).toHaveBeenCalled();
+            expect(sendContextDataFromControllerStateSpy).toHaveBeenCalled();
             expect(webviewManager.sendMessage).toHaveBeenCalledWith({ type: 'IS_BUSY', data: true });
         });
 
-        it('calls sendContextData when transitioning from idle to active', async () => {
+        it('calls sendContextDataFromControllerState when transitioning from idle to active', async () => {
             const solutionManager = solutionManagerFactory();
             const main = manageSolutionWebviewMainFactory({
                 solutionManager,
                 webviewManager
             });
             (main as any).webviewManager.isPanelActive = jest.fn().mockReturnValue(true); // Simulate active panel
 
-            const sendContextDataSpy = jest.spyOn(main as any, 'sendContextData').mockResolvedValue(undefined);
+            const sendContextDataFromControllerStateSpy = jest.spyOn(main as any, 'sendContextDataFromControllerState').mockResolvedValue(undefined);
 
             await main.activate(context as vscode.ExtensionContext);
 
@@ -333,7 +333,7 @@ describe('ContextSelectionWebviewMain', () => {
 
             await waitTimeout();
 
-            expect(sendContextDataSpy).toHaveBeenCalled();
+            expect(sendContextDataFromControllerStateSpy).toHaveBeenCalled();
         });
 
         it('does call sendContextData when transitioning from active to idle', async () => {

src/views/manage-solution/manage-solution-webview-main.ts

@@ -122,7 +122,7 @@ export class ManageSolutionWebviewMain {
         const activeTargetTypeUpdated = await this.controller.ensureActiveTargetTypeName();
 
         if (csolutionChanged || externalFilesChanged || activeTargetTypeUpdated) {
-            await this.sendContextData();
+            await this.sendContextDataFromControllerState();
         }
 
         this.setBusyState(false);
@@ -381,6 +381,10 @@ export class ManageSolutionWebviewMain {
             return;
         }
 
+        await this.sendContextDataFromControllerState();
+    }
+
+    private async sendContextDataFromControllerState(): Promise<void> {
         const controller = this.controller;
         await controller.getAvailableCoreNames();
         await Promise.all([