Open view via the Command Palette (#93)

Author: mguzmanm

src/views/manage-components-packs/components-packs-actions.ts

@@ -300,7 +300,7 @@ s    */
                 });
         };
 
-        componentTree.classes.forEach(cclass => {
+        componentTree.classes?.forEach(cclass => {
             cclass.bundles?.forEach(bundle => {
                 bundle.cgroups?.forEach(group => {
                     processLayerPaths(group.aggregates);

src/views/manage-components-packs/components-packs-webview-main.test.ts

@@ -188,10 +188,21 @@ describe('ComponentsPacksWebviewMain', () => {
         });
 
 
-        it('does not call openWebview when node is undefined', async () => {
+        it('calls openWebview with valid project when node is undefined', async () => {
+            jest.spyOn(componentsPacksWebviewMain as any, 'getValidProjectId').mockReturnValue(projectPath);
+            await (componentsPacksWebviewMain as any).handleWebviewCommand(undefined);
+
+            expect((componentsPacksWebviewMain as any).openWebview).toHaveBeenCalledTimes(1);
+            expect((componentsPacksWebviewMain as any).openWebview).toHaveBeenCalledWith(projectPath, undefined);
+        });
+
+        it('shows warning when node is undefined and no valid project exists', async () => {
+            jest.spyOn(componentsPacksWebviewMain as any, 'getValidProjectId').mockReturnValue(undefined);
+
             await (componentsPacksWebviewMain as any).handleWebviewCommand(undefined);
 
             expect((componentsPacksWebviewMain as any).openWebview).not.toHaveBeenCalled();
+            expect(messageProvider.showWarningMessage).toHaveBeenCalledWith('No valid project found in the active solution.');
         });
     });
 

src/views/manage-components-packs/components-packs-webview-main.ts

@@ -113,7 +113,16 @@ export class ComponentsPacksWebviewMain {
     private async handleWebviewCommand(treeNode: COutlineItem | undefined) {
         if (treeNode) {
             await this.openWebview(treeNode.cprojectPath, treeNode.clayerPath);
+            return;
+        }
+
+        const projectId = this.getValidProjectId();
+        if (!projectId) {
+            this.messageProvider.showWarningMessage('No valid project found in the active solution.');
+            return;
         }
+
+        await this.openWebview(projectId, undefined);
     }
 
     private projectFromPath(path: string | undefined): string {
@@ -131,7 +140,8 @@ export class ComponentsPacksWebviewMain {
             return; // nothing to show
         }
 
-        const reload = this.projectFromPath(this.currentProject?.project.projectId) !== this.projectFromPath(cprojectPath);
+        const reload = this.currentProject === undefined ||
+            this.projectFromPath(this.currentProject.project.projectId) !== this.projectFromPath(cprojectPath);
         const csolution = this.solutionManager.getCsolution();
         if (csolution) {
             this.currentProject = { solutionPath: csolution.solutionPath, project: createProject(cprojectPath) };
@@ -217,7 +227,7 @@ export class ComponentsPacksWebviewMain {
         }
 
         const latestUsedItems = usedItems ?? await this.csolutionService.getUsedItems({ context: actx });
-        if (this.usedItems?.packs.length !== latestUsedItems.packs.length || this.usedItems?.components.length !== latestUsedItems.components.length) {
+        if (this.usedItems?.packs?.length !== latestUsedItems.packs?.length || this.usedItems?.components?.length !== latestUsedItems.components?.length) {
             return true;
         }
 
@@ -228,8 +238,8 @@ export class ComponentsPacksWebviewMain {
             packs: [...(this.usedItems?.packs ?? [])].sort((a, b) => a.pack.localeCompare(b.pack)).map(packMapper),
         };
         const usedItemsSorted = {
-            components: [...latestUsedItems.components].sort((a, b) => a.id.localeCompare(b.id)).map(componentMapper),
-            packs: [...latestUsedItems.packs].sort((a, b) => a.pack.localeCompare(b.pack)).map(packMapper),
+            components: [...(latestUsedItems.components ?? [])].sort((a, b) => a.id.localeCompare(b.id)).map(componentMapper),
+            packs: [...(latestUsedItems.packs ?? [])].sort((a, b) => a.pack.localeCompare(b.pack)).map(packMapper),
         };
         const usedItemsChanged = !isDeepStrictEqual(localUsedItemsSorted, usedItemsSorted);
         return usedItemsChanged;