Skip to content

Commit e2df23c

Browse files
authored
Call RPC resolve with layer path if needed (#217)
1 parent 40a4cf5 commit e2df23c

3 files changed

Lines changed: 40 additions & 3 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"csolution": {
3838
"uv2csolutionVersion": "1.6.0",
3939
"toolboxVersion": "nightly",
40-
"rpcVersion": "0.0.9"
40+
"rpcVersion": "0.0.10"
4141
},
4242
"scripts": {
4343
"preprepare": "npm run download:rpc-interface",

src/views/manage-components-packs/components-packs-webview-main.test.ts

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1621,7 +1621,35 @@ describe('ComponentsPacksWebviewMain', () => {
16211621
await (componentsPacksWebviewMain as any).resolveComponents();
16221622

16231623
expect(resolveMock).toHaveBeenCalledTimes(1);
1624-
expect(resolveMock).toHaveBeenCalledWith({ context: 'ctx1' });
1624+
expect(resolveMock).toHaveBeenCalledWith({
1625+
context: 'ctx1',
1626+
options: {
1627+
layer: '',
1628+
explicitVersion: '',
1629+
explicitVendor: false,
1630+
},
1631+
});
1632+
});
1633+
1634+
it('passes selected layer path to resolve options when selected target is a layer', async () => {
1635+
(componentsPacksWebviewMain as any).selectedContext = {
1636+
label: 'Layer: App',
1637+
key: 'layer-key',
1638+
path: 'layers/app.clayer.yml',
1639+
relativePath: 'layers/app.clayer.yml',
1640+
type: 'layer',
1641+
};
1642+
1643+
await (componentsPacksWebviewMain as any).resolveComponents();
1644+
1645+
expect(resolveMock).toHaveBeenCalledWith({
1646+
context: 'ctx1',
1647+
options: {
1648+
layer: 'layers/app.clayer.yml',
1649+
explicitVersion: '',
1650+
explicitVendor: false,
1651+
},
1652+
});
16251653
});
16261654

16271655
it('calls getComponentsTree with active context and scope', async () => {

src/views/manage-components-packs/components-packs-webview-main.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -827,7 +827,16 @@ export class ComponentsPacksWebviewMain {
827827

828828
private async resolveComponents(): Promise<void> {
829829
const activeContext = this.getActiveContext();
830-
await this.csolutionService.resolve({ context: activeContext });
830+
const selectedTarget = this.getSelectedTargetSetData();
831+
const selectedLayerPath = selectedTarget?.type === 'layer' ? selectedTarget.path : '';
832+
await this.csolutionService.resolve({
833+
context: activeContext,
834+
options: {
835+
layer: selectedLayerPath,
836+
explicitVersion: '',
837+
explicitVendor: false,
838+
},
839+
});
831840
await this.sendSolutionData();
832841
await this.sendDirtyState();
833842
};

0 commit comments

Comments
 (0)