Remove Save button

Author: edriouk

src/views/manage-solution/view/components/manage-solution.test.tsx

@@ -355,51 +355,13 @@ describe('ContextSelection', () => {
         expect(listener).toHaveBeenCalledWith({ type: 'GET_CONTEXT_SELECTION_DATA' });
     });
 
-    it('calls messageHandler.push with SAVE_CONTEXT_SELECTION when Save button is clicked', () => {
+    it('does not render the Save button', () => {
         createContextSelectionComponent();
 
         postGenericDataContext();
 
-        // Simulate state.isDirty to enable the Save button
-        React.act(() => {
-            messageHandler.postWindowMessage({ type: 'IS_DIRTY', data: true });
-        });
-
         const saveButton = container.querySelector('.save-button');
-        expect(saveButton).not.toBeNull();
-        expect(saveButton?.getAttribute('disabled')).toBeNull();
-
-        React.act(() => {
-            if (saveButton) {
-                fireEvent.click(saveButton);
-            }
-        });
-
-        expect(listener).toHaveBeenCalledWith({ type: 'SAVE_CONTEXT_SELECTION' });
-    });
-
-    it('does not call messageHandler.push with SAVE_CONTEXT_SELECTION when Save button is disabled', () => {
-        createContextSelectionComponent();
-
-        postGenericDataContext();
-
-        // Simulate state.isDirty to disable the Save button
-        React.act(() => {
-            messageHandler.postWindowMessage({ type: 'IS_DIRTY', data: false });
-        });
-
-        const saveButton = container.querySelector('.save-button');
-        expect(saveButton).not.toBeNull();
-        expect(saveButton?.getAttribute('disabled')).not.toBeNull();
-
-        React.act(() => {
-            if (saveButton) {
-                fireEvent.click(saveButton);
-            }
-        });
-
-        // Must NOT call SAVE_CONTEXT_SELECTION
-        expect(listener).not.toHaveBeenCalledWith({ type: 'SAVE_CONTEXT_SELECTION' });
+        expect(saveButton).toBeNull();
     });
 
     describe('test change handlers', () => {

src/views/manage-solution/view/components/manage-solution.tsx

@@ -156,10 +156,6 @@ export const ManageSolution = (props: ManageSolutionProps) => {
         props.messageHandler.push({ type: 'SET_DEBUGGER', name });
     }, [props.messageHandler]);
 
-    const clickSave = React.useCallback(() => {
-        props.messageHandler.push({ type: 'SAVE_CONTEXT_SELECTION' });
-    }, [props.messageHandler]);
-
     const changeAutoUpdate = React.useCallback((e: CheckboxChangeEvent) => {
         props.messageHandler.push({ type: 'SET_AUTO_UPDATE', value: e.target.checked });
         dispatch({ type: 'INCOMING_MESSAGE', message: { type: 'AUTO_UPDATE', data: e.target.checked } });
@@ -276,7 +272,7 @@ export const ManageSolution = (props: ManageSolutionProps) => {
     }, [adapter, selectedDebugAdapter, getProperty, getScaledProperty, keyFor]);
 
     const showCoreSelector = state.solutionData.availableCoreNames !== undefined && state.solutionData.availableCoreNames.length > 1;
-    const debugAdapterConfigurationDocsUrl= 'https://mdk-packs.github.io/vscode-cmsis-solution-docs/debug.html#configure-run-and-debug';
+    const debugAdapterConfigurationDocsUrl = 'https://mdk-packs.github.io/vscode-cmsis-solution-docs/debug.html#configure-run-and-debug';
     const externalLink = (link: string, title: string, external?: boolean): React.JSX.Element => {
         return (<Button
             color="default"
@@ -306,10 +302,6 @@ export const ManageSolution = (props: ManageSolutionProps) => {
                     },
                     token: { fontSize: 13, sizeStep: 4, borderRadius: 3 }
                 }}>
-                    <section className='stickyHeader'>
-                        <Button disabled={!state.isDirty} style={{ minWidth: '100px' }} type='primary' onClick={clickSave} className='save-button'>Save</Button>
-                    </section>
-
                     <Spin spinning={state.busy} indicator={<LoadingOutlined spin={true} />} size='large'>
                         <section className="manage-solution-section">