Skip to content

Resolve file links in cbuild*.yml files#109

Merged
brondani merged 5 commits into
mainfrom
fix/90-cbuild
Mar 24, 2026
Merged

Resolve file links in cbuild*.yml files#109
brondani merged 5 commits into
mainfrom
fix/90-cbuild

Conversation

@edriouk
Copy link
Copy Markdown
Collaborator

@edriouk edriouk commented Mar 24, 2026

Fixes

Changes

Improvements after failed review :

  • extend resolver to cbuild.yml, *cbuild-idx.yml and *.cgen.yml files
  • expand ${CMSIS_PACK_ROOT}
  • add tests for new functionality

Screenshots

image

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 24, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA c4f22c7.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@edriouk edriouk requested review from brondani and Copilot and removed request for Copilot March 24, 2026 14:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the VS Code document-linking support so users can Ctrl+Click/open referenced files from additional CMSIS YAML artifacts (notably *.cbuild*.yml and *.cgen.yml), including resolving ${CMSIS_PACK_ROOT}-based paths.

Changes:

  • Register document link providers for *.cgen.{yml,yaml} and *.cbuild{,-idx,-run}.yml files.
  • Enhance ReferenceLinkProvider to handle more reference tags and expand ${CMSIS_PACK_ROOT} (with optional skipping of RPC variable expansion for generated build files).
  • Add/update unit tests for the new selectors and cbuild-link behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/views/solution-outline/tree-structure/solution-outline-file-item.ts Adjusts ${CMSIS_PACK_ROOT} detection in solution outline file nodes.
src/solutions/language-features/solution-language-features-provider.ts Adds new document selectors and registers an additional link provider for build YAMLs.
src/solutions/language-features/solution-language-features-provider.test.ts Updates activation test to expect both link providers to be registered.
src/solutions/language-features/reference-link-provider.ts Adds cbuild-aware behavior, expands ${CMSIS_PACK_ROOT}, and broadens supported reference tags.
src/solutions/language-features/reference-link-provider.test.ts Adds test coverage for cbuild link behavior and ${CMSIS_PACK_ROOT} expansion.

Comment thread src/solutions/language-features/reference-link-provider.ts Outdated
Comment thread src/solutions/language-features/reference-link-provider.ts Outdated
Comment thread src/solutions/language-features/reference-link-provider.ts Outdated
Comment thread src/solutions/language-features/reference-link-provider.ts
Comment thread src/solutions/language-features/reference-link-provider.test.ts Outdated
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 24, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (3)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
.../solution-outline/tree-structure/solution-outline-file-item.ts100.0%
Coverage rating: A Coverage rating: B
src/solutions/language-features/reference-link-provider.ts95.2%68
Coverage rating: A Coverage rating: A
...tions/language-features/solution-language-features-provider.ts100.0%
Total95.7%
🤖 Increase coverage with AI coding...

In the `fix/90-cbuild` branch, add test coverage for this new code:

- `src/solutions/language-features/reference-link-provider.ts` -- Line 68

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

edriouk and others added 3 commits March 24, 2026 16:01
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread src/solutions/language-features/reference-link-provider.ts
Copy link
Copy Markdown
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit ebcffa4 into main Mar 24, 2026
16 checks passed
@brondani brondani deleted the fix/90-cbuild branch March 24, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants