Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (1)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #111 on Windows where triggering the merge action from the solution outline no longer opens the VS Code merge UI, by changing how the VS Code CLI merge command is constructed and executed and by extending unit test coverage around the merge flow.
Changes:
- Reworked merge CLI invocation to build a quoted command string and added path validation before execution.
- Updated merge execution to use
exec(command, { windowsHide: true })and expanded unit tests for cross-platform and Windows-specific behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/views/solution-outline/commands/merge-command.ts |
Replaces array+shell-quote command building with a validated, quoted command string and updates merge execution behavior. |
src/views/solution-outline/commands/merge-command.test.ts |
Adds/reshapes tests for path validation, non-zero exit behavior, and Windows path handling. |
edriouk
left a comment
There was a problem hiding this comment.
Tested locally on Windows, works good
However copilot recommendations should be revised an some definitely implemented

Fixes
#111
Changes
Screenshots
Checklist