Fix/add relative path configuration debug adapters#12
Conversation
…iguration and update copyright notices
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
…solution-webview-main files
There was a problem hiding this comment.
Pull request overview
Adds support for choosing whether file paths coming from debug-adapter UI “file” options are stored/returned as relative to the solution or as absolute filesystem paths, enabling adapters like uVision to require absolute paths while preserving current default behavior.
Changes:
- Introduces
PathType('absolute' | 'relative') and plumbs it through the Manage Solution webview’sSELECT_FILEmessage options. - Updates file selection handling in the extension host to return absolute vs. relative paths based on
pathType(default remains relative). - Updates unit tests around
SELECT_FILE(but currently in a way that conflicts with the intended default behavior).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/manage-solution/view/components/manage-solution.tsx | Reads per-option path-type from debug-adapter UI options and sends it with SELECT_FILE. |
| src/views/manage-solution/messages.ts | Adds PathType and extends FileSelectorOptionsType to include pathType. |
| src/views/manage-solution/manage-solution-webview-main.ts | Implements absolute-vs-relative path behavior when returning FILE_SELECTED. |
| src/views/manage-solution/manage-solution-webview-main.test.ts | Updates expectations for SELECT_FILE / FILE_SELECTED behavior. |
| src/debug/debug-adapters-yaml-file.ts | Extends UI option typing to include 'path-type' on file options. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ttps://github.com/Open-CMSIS-Pack/vscode-cmsis-solution into fix/add-relative-path-configuration-debug-adapters
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Files with Diff Coverage (2)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
Addresses CodeQL issue #12
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
LGTM, but @edriouk may be able to verify the change on Windows. |
…ttps://github.com/Open-CMSIS-Pack/vscode-cmsis-solution into fix/add-relative-path-configuration-debug-adapters

Fixes
ARM-software/vscode-cmsis-csolution#502
Changes
Screenshots
Checklist