Skip to content

Load context RPC data on each convert#13

Merged
edriouk merged 3 commits into
mainfrom
solutionRpcData
Mar 9, 2026
Merged

Load context RPC data on each convert#13
edriouk merged 3 commits into
mainfrom
solutionRpcData

Conversation

@edriouk
Copy link
Copy Markdown
Collaborator

@edriouk edriouk commented Mar 5, 2026

Fixes

This PR is a per-requisite for fixing following issues:
Problems with Loading Solution (cbuild setup integration) #30
CMSIS-View: shows "Loading..." on minimal debugger setup 
CMSIS Outline View: invalid filename when using access sequence
UX improvement: allow to open related files on other nodes, too

Changes

  • added SolutionRpcData interface and corresponding class. Queries and keeps RPC data: device, board and variables
  • RPC data update is performed at every convert completion
  • Processing environment change event is rejected if solution is not yet initialized (redundant event by loading a workspace)

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 6, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.04%.

Modified Files with Diff Coverage (4)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
src/solutions/files/csolution-wrap.ts100.0%
Coverage rating: A Coverage rating: A
src/solutions/csolution.ts92.3%417
Coverage rating: B Coverage rating: B
src/solutions/solution-manager.ts57.1%106-136, 223
New file Coverage rating: B
src/solutions/solution-rpc-data.ts87.5%71-75, 82, 86-88
Total84.0%
🤖 Increase coverage with AI coding...

In the `solutionRpcData` branch, add test coverage for this new code:

- `src/solutions/csolution.ts` -- Line 417
- `src/solutions/solution-manager.ts` -- Lines 106-136 and 223
- `src/solutions/solution-rpc-data.ts` -- Lines 71-75, 82, and 86-88

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@edriouk edriouk marked this pull request as ready for review March 9, 2026 10:18
@edriouk edriouk requested a review from brondani March 9, 2026 11:04
Comment thread src/solutions/solution-manager.ts Outdated
Co-authored-by: Daniel Brondani <daniel.brondani@arm.com>
@edriouk edriouk requested a review from brondani March 9, 2026 13:26
Copy link
Copy Markdown
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edriouk edriouk merged commit 71b3603 into main Mar 9, 2026
21 of 24 checks passed
@edriouk edriouk deleted the solutionRpcData branch March 9, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants