Skip to content

Fix: update tree on target change#144

Merged
edriouk merged 2 commits into
mainfrom
fix/70
Mar 31, 2026
Merged

Fix: update tree on target change#144
edriouk merged 2 commits into
mainfrom
fix/70

Conversation

@edriouk
Copy link
Copy Markdown
Collaborator

@edriouk edriouk commented Mar 30, 2026 •
edited
Loading

Fixes

Changes

  • change cbuild filename associated with the project when target changes

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@edriouk edriouk requested a review from Copilot March 30, 2026 14:35
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 30, 2026 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA dc8cdec.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@edriouk edriouk requested a review from mguzmanm March 30, 2026 14:37
Copilot AI reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the CMSIS View project tree not refreshing when the active target-type changes by ensuring the correct .cbuild.yml file is (re)loaded for a project when the indexed cbuild filename changes.

Changes:

  • Resolve the cbuild file path once per entry and reuse it consistently.
  • When reusing an existing CbuildFile instance, load it using the newly resolved path so the underlying filename updates on target/context changes.

Comment thread src/solutions/files/cbuild-idx-file.ts
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 30, 2026 •
edited
Loading

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.01%.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/solutions/files/cbuild-idx-file.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

jkrech
jkrech previously approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How about the outstanding test recommended by copilot?

@edriouk edriouk requested a review from jkrech March 30, 2026 15:45
mguzmanm
mguzmanm approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mguzmanm mguzmanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edriouk edriouk merged commit 9b44ed2 into main Mar 31, 2026
12 checks passed
@edriouk edriouk deleted the fix/70 branch March 31, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mguzmanm mguzmanm mguzmanm approved these changes

@jkrech jkrech Awaiting requested review from jkrech

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edriouk @jkrech @mguzmanm