Skip to content

Add memory inspector configurations#149

Merged
mguzmanm merged 2 commits into
mainfrom
memory_inspector_configurations
Apr 1, 2026
Merged

Add memory inspector configurations#149
mguzmanm merged 2 commits into
mainfrom
memory_inspector_configurations

Conversation

@mguzmanm
Copy link
Copy Markdown
Contributor

@mguzmanm mguzmanm commented Apr 1, 2026

Fixes

Changes

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA eb80d04.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@qltysh
Copy link
Copy Markdown

qltysh Bot commented Apr 1, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.01%.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
src/debug/debug-launch-provider.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to improve the default user experience when viewing embedded targets in the VS Code Memory Inspector by setting preferred default configuration values during debug task updates.

Changes:

  • Add logic in debug task update flow to set default memory-inspector settings when they are not already configured.
  • Add/adjust unit tests covering the new default-setting behavior and ensuring existing settings are not overwritten.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/debug/debug-launch-provider.ts Sets Memory Inspector configuration defaults (and keeps existing debug-default behavior) during handleUpdateDebugTasks().
src/debug/debug-launch-provider.test.ts Adds test coverage for Memory Inspector defaults and updates existing expectations to avoid false failures.

Comment thread src/debug/debug-launch-provider.ts
Comment thread src/debug/debug-launch-provider.ts
@mguzmanm mguzmanm force-pushed the memory_inspector_configurations branch from cc45ee0 to aadef7d Compare April 1, 2026 13:38
@mguzmanm mguzmanm requested review from edriouk April 1, 2026 13:55
@mguzmanm mguzmanm merged commit 6fd792a into main Apr 1, 2026
12 checks passed
@mguzmanm mguzmanm deleted the memory_inspector_configurations branch April 1, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants