Refactor manage Layers

[edriouk]

Fixes

• [Refactor]: Move temporary layer and compiler data from csolution #145

Changes

This PR removes Configure Solution’s dependency on temporary CSolution state and switches compiler/layer discovery to an explicit event-driven flow. SolutionConverter now publishes configure data through a new SolutionEventHub payload, while ManageLayersWebviewMain consumes that payload directly instead of reading transient selectCompiler and variablesConfigurations fields from the solution model.

As part of the cleanup, the temporary fields were removed from CSolution, obsolete cbuild-based layer error handling was dropped from Manage Layers, and the related unit tests were updated. The affected solution event hub and converter tests are passing.

Checklist

• 🤖 This change is covered by unit tests (if applicable).
• 🤹 Manual testing has been performed (if necessary).
• 🛡️ Security impacts have been considered (if relevant).
• 📖 Documentation updates are complete (if required).
• 🧠 Third-party dependencies and TPIP updated (if required).

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 52f863b.

Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

[Copilot]

Pull request overview

This PR refactors the “Configure Solution / Manage Layers” flow to remove reliance on transient state stored on CSolution, replacing it with an explicit event-driven payload published by SolutionConverter via SolutionEventHub and consumed by ManageLayersWebviewMain.

Changes:

• Added a new ConfigureSolutionData event to SolutionEventHub and corresponding unit tests.
• Updated SolutionConverterImpl to emit detected compiler/layer configuration data through the event hub instead of mutating CSolution.
• Updated ManageLayersWebviewMain to consume the emitted configure payload (and removed legacy cbuild-based layer error handling).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/views/manage-layers/manage-layers-webview-main.ts	Switches Manage Layers to consume configure data via SolutionEventHub and removes legacy cbuild error parsing.
src/solutions/solution-event-hub.ts	Adds a new ConfigureSolutionData payload and corresponding event API.
src/solutions/solution-event-hub.test.ts	Extends tests to cover the new configure-data event and emitter registration.
src/solutions/solution-converter.ts	Emits configure-data events based on convert/discover results; removes dependency on SolutionManager.
src/solutions/solution-converter.test.ts	Updates converter tests to assert configure-data emission.
src/solutions/csolution.ts	Removes transient selectCompiler / variablesConfigurations state and setters.
src/desktop/extension.ts	Updates DI wiring for the updated converter and Manage Layers constructor signature.

[qltysh]

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.75%.

Modified Files with Diff Coverage (3)

Rating	File	% Diff	Uncovered Line #s
	src/solutions/solution-event-hub.ts	100.0%
	src/views/manage-layers/manage-layers-webview-main.ts	88.9%	175-176, 214
	src/solutions/solution-converter.ts	100.0%
	Total	92.5%

🤖 Increase coverage with AI coding...

In the `manage_layers_compiler` branch, add test coverage for this new code:

- `src/views/manage-layers/manage-layers-webview-main.ts` -- Lines 175-176 and 214

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.