Skip to content

Fix potential shell quotation issue in merge-command#17

Merged
JonatanAntoni merged 2 commits into
mainfrom
fix-shell-quote
Mar 9, 2026
Merged

Fix potential shell quotation issue in merge-command#17
JonatanAntoni merged 2 commits into
mainfrom
fix-shell-quote

Conversation

@JonatanAntoni
Copy link
Copy Markdown
Member

@JonatanAntoni JonatanAntoni commented Mar 5, 2026

Fixes

Changes

  • Use shell-quote instead of manual quoting a shell command string

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@types/shell-quote 1.7.5 🟢 6.5
Details
CheckScoreReason
Maintained🟢 1030 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 8Found 23/28 approved changesets -- score normalized to 8
Packaging⚠️ -1packaging workflow not detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
License🟢 9license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
Signed-Releases⚠️ -1no releases found
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Fuzzing⚠️ 0project is not fuzzed
npm/shell-quote 1.8.3 🟢 4.1
Details
CheckScoreReason
Code-Review⚠️ 1Found 3/30 approved changesets -- score normalized to 1
Maintained⚠️ 11 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 1
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
Binary-Artifacts🟢 10no binaries found in the repo
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • package-lock.json

mguzmanm
mguzmanm previously approved these changes Mar 9, 2026
Copy link
Copy Markdown
Contributor

@mguzmanm mguzmanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 9, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.03%.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: F Coverage rating: F
src/views/solution-outline/commands/merge-command.ts80.0%190
Total80.0%
🤖 Increase coverage with AI coding...

In the `fix-shell-quote` branch, add test coverage for this new code:

- `src/views/solution-outline/commands/merge-command.ts` -- Line 190

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@mguzmanm
Copy link
Copy Markdown
Contributor

mguzmanm commented Mar 9, 2026

The failed unit test is not related to the changes in this PR.

`PASS src/views/manage-solution/manage-solution-webview-main.test.ts
FAIL src/solutions/active-solution-tracker.test.ts
● ActiveSolutionTracker › searches for solution files on activation

expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0

  102 |         await waitTimeout();
  103 |
> 104 |         expect(vscode.workspace.findFiles).toHaveBeenCalledTimes(1);
      |                                            ^
  105 |         expect(vscode.workspace.findFiles).toHaveBeenCalledWith(ActiveSolutionTrackerImpl.GLOB_PATTERN, undefined);
  106 |     });
  107 |

  at Object.<anonymous> (src/solutions/active-solution-tracker.test.ts:104:44)`

@JonatanAntoni JonatanAntoni merged commit 70d2533 into main Mar 9, 2026
23 of 25 checks passed
@JonatanAntoni JonatanAntoni deleted the fix-shell-quote branch March 9, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants