Skip to content

Nightly tests updates#203

Merged
soumeh01 merged 4 commits into
mainfrom
update-nightly
Apr 20, 2026
Merged

Nightly tests updates#203
soumeh01 merged 4 commits into
mainfrom
update-nightly

Conversation

@soumeh01
Copy link
Copy Markdown
Collaborator

@soumeh01 soumeh01 commented Apr 20, 2026

Changes

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@qltysh
Copy link
Copy Markdown

qltysh Bot commented Apr 20, 2026

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@soumeh01 soumeh01 marked this pull request as ready for review April 20, 2026 10:52
@mguzmanm mguzmanm requested a review from Copilot April 20, 2026 11:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the E2E nightly build workflow to account for solution “inactive/closed” state persistence introduced in PR #196, ensuring tests explicitly open/close solutions when switching workspaces.

Changes:

  • Add “Close Solution” to post-test cleanup to reset solution state between E2E cases.
  • Explicitly open a solution in the workspace before waiting for tool activation / build steps.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/e2e-tests/infrastructure/vscode-driver.ts Extends E2E cleanup routine to close the active CMSIS solution between tests.
src/e2e-tests/build.test.ts Opens a solution explicitly after switching workspaces to align with new “keep closed solutions closed” behavior.
Comments suppressed due to low confidence (1)

src/e2e-tests/infrastructure/vscode-driver.ts:227

  • cleanupTestState() wraps all cleanup commands in a single try/catch, so if the newly added CMSIS: Close Solution command fails, the remaining cleanup steps (close editors/clear notifications/kill terminals/reset view locations) will be skipped. Consider executing each cleanup command in its own guarded block (or a small helper that ignores individual failures) so the rest of the cleanup still runs when one command is unavailable or errors.
            await runningApp.pageDriver.getCommands().runCommandFromPalette('CMSIS: Close Solution');
            await runningApp.pageDriver.getCommands().runCommandFromPalette('View: Close All Editors');
            await runningApp.pageDriver.getCommands().runCommandFromPalette('Notifications: Clear All Notifications');
            await runningApp.pageDriver.getCommands().runCommandFromPalette('View: Kill All Terminals');
            await runningApp.pageDriver.getCommands().runCommandFromPalette('View: Reset View Locations');

Comment thread src/e2e-tests/build.test.ts
soumeh01 and others added 2 commits April 20, 2026 13:58
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumeh01 soumeh01 merged commit bada274 into main Apr 20, 2026
17 of 18 checks passed
@soumeh01 soumeh01 deleted the update-nightly branch April 20, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants