Nightly tests updates#203
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
11d2291 to
0d4569f
Compare
0d4569f to
c3caa44
Compare
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
There was a problem hiding this comment.
Pull request overview
Updates the E2E nightly build workflow to account for solution “inactive/closed” state persistence introduced in PR #196, ensuring tests explicitly open/close solutions when switching workspaces.
Changes:
- Add “Close Solution” to post-test cleanup to reset solution state between E2E cases.
- Explicitly open a solution in the workspace before waiting for tool activation / build steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/e2e-tests/infrastructure/vscode-driver.ts | Extends E2E cleanup routine to close the active CMSIS solution between tests. |
| src/e2e-tests/build.test.ts | Opens a solution explicitly after switching workspaces to align with new “keep closed solutions closed” behavior. |
Comments suppressed due to low confidence (1)
src/e2e-tests/infrastructure/vscode-driver.ts:227
cleanupTestState()wraps all cleanup commands in a single try/catch, so if the newly addedCMSIS: Close Solutioncommand fails, the remaining cleanup steps (close editors/clear notifications/kill terminals/reset view locations) will be skipped. Consider executing each cleanup command in its own guarded block (or a small helper that ignores individual failures) so the rest of the cleanup still runs when one command is unavailable or errors.
await runningApp.pageDriver.getCommands().runCommandFromPalette('CMSIS: Close Solution');
await runningApp.pageDriver.getCommands().runCommandFromPalette('View: Close All Editors');
await runningApp.pageDriver.getCommands().runCommandFromPalette('Notifications: Clear All Notifications');
await runningApp.pageDriver.getCommands().runCommandFromPalette('View: Kill All Terminals');
await runningApp.pageDriver.getCommands().runCommandFromPalette('View: Reset View Locations');
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Changes
Checklist