Skip to content

Fix intermittently failing unit test for ActiveSolutionTracker#38

Merged
edriouk merged 1 commit into
mainfrom
active_solution_tracker
Mar 11, 2026
Merged

Fix intermittently failing unit test for ActiveSolutionTracker#38
edriouk merged 1 commit into
mainfrom
active_solution_tracker

Conversation

@mguzmanm
Copy link
Copy Markdown
Contributor

@mguzmanm mguzmanm commented Mar 9, 2026

Fixes

Changes

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@mguzmanm mguzmanm requested a review from Copilot March 9, 2026 17:27
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves stability of ActiveSolutionTracker unit tests by replacing fixed delays with deterministic waits, reducing test flakiness caused by timing variance during async activation/refresh.

Changes:

  • Replace waitTimeout() usage with waitForCondition() in tests that need to wait until workspace.findFiles is triggered.
  • Replace waitTimeout() usage with waitForEvent() in tests that can wait on tracker events.

@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 9, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.09%.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@edriouk
Copy link
Copy Markdown
Collaborator

edriouk commented Mar 9, 2026

I'm not sure if it solves the problem, I have submitted another fix: #37

@mguzmanm
Copy link
Copy Markdown
Contributor Author

mguzmanm commented Mar 10, 2026

@edriouk Please, explain uncertainty.

@mguzmanm mguzmanm requested a review from edriouk March 10, 2026 08:25
@mguzmanm mguzmanm changed the title Fix unit test Fix intermittently failing unit test for ActiveSolutionTracker Mar 10, 2026
@edriouk edriouk merged commit f0c4c3c into main Mar 11, 2026
16 checks passed
@edriouk edriouk deleted the active_solution_tracker branch March 11, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants