Skip to content

Remove redundant test data#42

Merged
arneschmid merged 1 commit into
mainfrom
remove_CubeMX_code
Mar 11, 2026
Merged

Remove redundant test data#42
arneschmid merged 1 commit into
mainfrom
remove_CubeMX_code

Conversation

@edriouk
Copy link
Copy Markdown
Collaborator

@edriouk edriouk commented Mar 11, 2026

Changes

  • remove redundant test data

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@edriouk edriouk requested a review from arneschmid March 11, 2026 11:52
@github-actions
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 11, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@mguzmanm mguzmanm requested a review from Copilot March 11, 2026 12:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces the size of the USBD CubeMX-based test fixture by removing vendor-generated STM32 HAL/CMSIS headers and associated metadata that are considered redundant for the repo’s tests.

Changes:

  • Removed multiple STM32U5xx HAL driver headers from the test-data solution.
  • Removed several CMSIS header files from the test-data solution.
  • Removed CubeMX metadata / generated board parameter header files from the test-data solution.

Reviewed changes

Copilot reviewed 33 out of 135 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/STM32U5xx_HAL_Driver/Inc/stm32u5xx_hal_gpio.h Removed redundant STM32 HAL header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/STM32U5xx_HAL_Driver/Inc/stm32u5xx_hal_flash_ex.h Removed redundant STM32 HAL header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/STM32U5xx_HAL_Driver/Inc/stm32u5xx_hal_exti.h Removed redundant STM32 HAL header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/STM32U5xx_HAL_Driver/Inc/stm32u5xx_hal_dma_ex.h Removed redundant STM32 HAL header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/STM32U5xx_HAL_Driver/Inc/stm32u5xx_hal_def.h Removed redundant STM32 HAL header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/STM32U5xx_HAL_Driver/Inc/stm32u5xx_hal_cortex.h Removed redundant STM32 HAL header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/LICENSE.txt Removed CMSIS license text from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Include/tz_context.h Removed redundant CMSIS header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Include/pmu_armv8.h Removed redundant CMSIS header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Include/pac_armv81.h Removed redundant CMSIS header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Include/mpu_armv8.h Removed redundant CMSIS header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Include/mpu_armv7.h Removed redundant CMSIS header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Include/cmsis_version.h Removed redundant CMSIS header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Include/cmsis_compiler.h Removed redundant CMSIS header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Include/cmsis_armcc.h Removed redundant CMSIS header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Include/cachel1_armv7.h Removed redundant CMSIS header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Device/ST/STM32U5xx/LICENSE.txt Removed ST device license note from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Device/ST/STM32U5xx/LICENSE.md Removed Apache license copy from ST device subtree in test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Device/ST/STM32U5xx/Include/system_stm32u5xx.h Removed redundant device system header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/Device/ST/STM32U5xx/Include/stm32u5xx.h Removed redundant device header from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/.mxproject Removed CubeMX project metadata from test fixture.
test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/MX_Device/Board/MX_Device.h Removed generated CubeMX parameter header from test fixture.
Comments suppressed due to low confidence (1)

test-data/solutions/USBD/Board/B-U585I-IOT02A/CubeMX/STM32CubeMX/Drivers/CMSIS/LICENSE.txt:1

  • Removing the CMSIS license file can create a compliance gap if any CMSIS (or other third-party) content still remains anywhere under Drivers/CMSIS/ in this test fixture. If you’re pruning only some CMSIS files, keep this license (or replace it with a minimal license/notice pointer and ensure the repo’s third-party notice mechanism references the retained CMSIS sources); only delete it if the entire licensed content covered by it is removed from the tree.

Copy link
Copy Markdown
Collaborator

@arneschmid arneschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arneschmid arneschmid merged commit 4b067a3 into main Mar 11, 2026
19 of 20 checks passed
@arneschmid arneschmid deleted the remove_CubeMX_code branch March 11, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants