Skip to content

Fix/manage solution file picker requestid#43

Merged
edriouk merged 13 commits into
mainfrom
fix/manage-solution-file-picker-requestid
Mar 13, 2026
Merged

Fix/manage solution file picker requestid#43
edriouk merged 13 commits into
mainfrom
fix/manage-solution-file-picker-requestid

Conversation

@arneschmid
Copy link
Copy Markdown
Collaborator

@arneschmid arneschmid commented Mar 11, 2026

Refactor Manage Solution file picker messaging to use [requestId] instead of DOM element IDs.

Fixes

Changes

  • Updated message types and backend wiring (SELECT_FILE / FILE_SELECTED) to pass [requestId].
  • Reworked UI file-selection handling to track pending requests in React state/ref logic, removing direct DOM lookup/mutation.
  • Updated tests to match the new request-based contract and ignore unmatched/empty file-selection responses.

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@arneschmid arneschmid marked this pull request as draft March 11, 2026 14:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 11, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 11, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.08%.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: C Coverage rating: C
src/views/manage-solution/view/components/manage-solution.tsx94.7%103
Coverage rating: C Coverage rating: C
src/views/manage-solution/manage-solution-webview-main.ts66.7%452
Total90.9%
🤖 Increase coverage with AI coding...

In the `fix/manage-solution-file-picker-requestid` branch, add test coverage for this new code:

- `src/views/manage-solution/manage-solution-webview-main.ts` -- Line 452
- `src/views/manage-solution/view/components/manage-solution.tsx` -- Line 103

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix/modernize Manage Solution’s file-picker message correlation (per PR description) and includes a small set of supporting type/test updates in the extension/webview code.

Changes:

  • Reordered Manage Solution component CSS imports.
  • Updated a Manage Solution webview main unit test to pass an explicit configurationProvider.
  • Added a global TypeScript declaration for importing *.css files and updated a solution manager test factory to include the activated load-state flag.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/views/manage-solution/view/components/manage-solution.tsx Import ordering change for CSS files in the Manage Solution React component.
src/views/manage-solution/manage-solution-webview-main.test.ts Adjusts test wiring to pass configurationProvider into the factory.
src/style.d.ts Adds declare module '*.css' to support CSS imports in TS.
src/solutions/solution-manager.factories.ts Extends SolutionLoadState factories to include the new activated field.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.


You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/views/manage-solution/manage-solution-webview-main.ts
Comment thread src/views/manage-solution/view/components/manage-solution.tsx
@arneschmid arneschmid marked this pull request as ready for review March 12, 2026 11:08
@arneschmid arneschmid self-assigned this Mar 12, 2026
@JonatanAntoni JonatanAntoni requested review from edriouk and removed request for JonatanAntoni March 12, 2026 14:39
@edriouk edriouk merged commit ed848f4 into main Mar 13, 2026
12 checks passed
@edriouk edriouk deleted the fix/manage-solution-file-picker-requestid branch March 13, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants