Skip to content

Fix compiler errors in test files#56

Merged
edriouk merged 1 commit into
mainfrom
fixCompileErrorsInTestFiles
Mar 12, 2026
Merged

Fix compiler errors in test files#56
edriouk merged 1 commit into
mainfrom
fixCompileErrorsInTestFiles

Conversation

@edriouk
Copy link
Copy Markdown
Collaborator

@edriouk edriouk commented Mar 12, 2026

Fixes

  • compilation error in two test files

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes TypeScript compilation errors in unit tests by aligning mocks and test factories with updated type signatures in the solution/load-state and open-file-external abstractions.

Changes:

  • Update OpenCommand tests to mock IOpenFileExternal.openFile() with a string return value.
  • Update SolutionLoadState test factories to include the newly required activated initializer.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/views/solution-outline/commands/open-command.test.ts Fixes test mocks to match openFile(): string return type.
src/solutions/solution-manager.factories.ts Adds activated to SolutionLoadState factories to satisfy makeFactory initializer requirements.

@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 12, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown
Collaborator

@soumeh01 soumeh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edriouk edriouk merged commit 6224e9b into main Mar 12, 2026
16 checks passed
@edriouk edriouk deleted the fixCompileErrorsInTestFiles branch March 12, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants