Skip to content

Populate CMSIS view for image-only solutions#86

Merged
brondani merged 7 commits into
mainfrom
imageOnlySolution1
Mar 19, 2026
Merged

Populate CMSIS view for image-only solutions#86
brondani merged 7 commits into
mainfrom
imageOnlySolution1

Conversation

@edriouk
Copy link
Copy Markdown
Collaborator

@edriouk edriouk commented Mar 19, 2026

Fixes

Changes

  • changed: add board and device nodes even no projects are specified in solution
  • added: image-only test case and corresponding test data
  • renamed: several variables for readability

Screenshots

image

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 19, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes CMSIS-View population for “image-only” solutions by ensuring hardware (board/device) nodes are created even when no projects are present, and adds test fixtures + a unit test to validate the behavior.

Changes:

  • Build the hardware subtree even when a cbuild has no associated cproject.
  • Add ImageOnly solution fixtures (single-core + multicore) and a reference tree dump.
  • Minor readability refactors via variable renames in outline item builders.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
test-data/solutions/ImageOnly/image-only.csolution.yml Adds a single-core image-only csolution fixture.
test-data/solutions/ImageOnly/image-only.cbuild-pack.yml Adds resolved pack data for the single-core fixture.
test-data/solutions/ImageOnly/image-only.cbuild-idx.yml Adds build index metadata for the single-core fixture.
test-data/solutions/ImageOnly/image-only-multicore.csolution.yml Adds a multicore image-only csolution fixture used by the new unit test.
test-data/solutions/ImageOnly/image-only-multicore.cbuild-pack.yml Adds resolved pack data for the multicore fixture.
test-data/solutions/ImageOnly/image-only-multicore.cbuild-idx.yml Adds build index metadata for the multicore fixture.
test-data/solutions/ImageOnly/CmsisViewTreeMulticoreRef.txt Reference dump to assert expected CMSIS-View tree output for multicore image-only solutions.
test-data/solutions/ImageOnly/.cmsis/image-only-multicore+CM0.dbgconf.base@0.0.2 Debug config base file used by the tree output.
test-data/solutions/ImageOnly/.cmsis/image-only-multicore+CM0.dbgconf Debug config file used by the tree output.
test-data/solutions/ImageOnly/.cmsis/image-only+CM0.dbgconf.base@0.0.2 Debug config base file for the single-core fixture.
test-data/solutions/ImageOnly/.cmsis/image-only+CM0.dbgconf Debug config file for the single-core fixture.
src/views/solution-outline/tree-structure/solution-outline-tree.ts Ensures hardware nodes are created regardless of project presence per build.
src/views/solution-outline/tree-structure/solution-outline-tree.test.ts Adds a unit test validating outline tree content for an image-only solution.
src/views/solution-outline/tree-structure/solution-outline-project-items.ts Variable renames to improve readability (no behavior change).
src/views/solution-outline/tree-structure/solution-outline-hardware-item.ts Variable renames to improve readability (no behavior change).

You can also share your feedback on Copilot code review. Take the survey.

Comment thread test-data/solutions/ImageOnly/image-only.csolution.yml
Comment thread test-data/solutions/ImageOnly/.cmsis/image-only-multicore+CM0.dbgconf.base@0.0.2 Outdated
Comment thread test-data/solutions/ImageOnly/.cmsis/image-only-multicore+CM0.dbgconf Outdated
Comment thread test-data/solutions/ImageOnly/.cmsis/image-only+CM0.dbgconf.base@0.0.2 Outdated
Comment thread test-data/solutions/ImageOnly/.cmsis/image-only+CM0.dbgconf
Comment thread src/views/solution-outline/tree-structure/solution-outline-tree.ts
Comment thread src/views/solution-outline/tree-structure/solution-outline-tree.test.ts Outdated
edriouk and others added 5 commits March 19, 2026 15:41
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@edriouk edriouk requested review from brondani and mguzmanm March 19, 2026 15:08
by default 'out' directory is ignored
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 19, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.03%.

Modified Files with Diff Coverage (3)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
...views/solution-outline/tree-structure/solution-outline-tree.ts100.0%
Coverage rating: B Coverage rating: B
...ution-outline/tree-structure/solution-outline-project-items.ts85.7%229-242
Coverage rating: A Coverage rating: A
...ution-outline/tree-structure/solution-outline-hardware-item.ts100.0%
Total94.6%
🤖 Increase coverage with AI coding...

In the `imageOnlySolution1` branch, add test coverage for this new code:

- `src/views/solution-outline/tree-structure/solution-outline-project-items.ts` -- Line 229-242

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit 177ef4e into main Mar 19, 2026
17 of 18 checks passed
@brondani brondani deleted the imageOnlySolution1 branch March 19, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants