update numpy dependency to >=2.0#358
Closed
clausmichele wants to merge 4 commits into
Closed
Conversation
This was referenced Jan 15, 2026
pjonsson
reviewed
Mar 1, 2026
| pyarrow = ">=15.0.2" | ||
| openeo = ">=0.36.0" | ||
| numpy = { version = "<2.0.0", optional = false } | ||
| numpy = { version = ">=2.0.0", optional = false } |
Contributor
There was a problem hiding this comment.
The functions used by this PR seem to exist in numpy 1.26 (https://numpy.org/doc/1.26/reference/generated/numpy.issubdtype.html for example), can the bound be lowered to >=1.26?
Collaborator
There was a problem hiding this comment.
I tested the changes locally with 1.26 now and can confirm it works, so I agree, lowering the bound to 1.26 makes sense!
pjonsson
reviewed
May 6, 2026
| def get_scalar_type(obj): | ||
| if np.isscalar(obj): | ||
| return np.obj2sctype(type(obj)) | ||
| return np.dtype(type(obj)) |
Contributor
There was a problem hiding this comment.
Looking at https://numpy.org/doc/stable/numpy_2_0_migration_guide.html for obj2sctype, should this be np.dtype(obj).type (or possibly np.dtype(type(obj)).type)?
Member
|
Solved this issue by merging this PR: #372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a specific reference to the updated parser supporting numpy 2.0 from here Open-EO/openeo-pg-parser-networkx#113
Once that PR gets merged, installing it from git can be removed from the
pyproject.tomlfile.