Added acceptable pixel tolerances feature for testing.#777
Conversation
soxofaan
left a comment
There was a problem hiding this comment.
some quick notes
I'm also not sure we have to use such a cryptic parameter "pxtol". Note that "rtol" and "atol" are just directly adaptations from numpy/array.
This pixel fraction tolerance is however a completely new parameter, so we can be less cryptic, e.g. "pixel_tolerance"
|
I think it's also important that this feature is covered with unit tests. Are you familiar with pytest and writing tests? |
Yes. I have done it a few times. I will try finding a way to add one. Or will ping you if I need help. |
I have added a simple test to capture all possibilities. Please let me know if I have to add more tests. |
|
FYI: I merged master in your feature branch, which hopefully fixes the unit test failure |
soxofaan
left a comment
There was a problem hiding this comment.
can you also add a changelog entry?
|
I will do it. |
|
thanks, |
Added a feature mentioned in this issue #776
Feature behavior