Skip to content

fix: sanitize error responses to prevent internal detail leakage #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pablo-ibco wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: sanitize error responses to prevent internal detail leakage #2456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions app/src/util/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,17 +466,14 @@ function errorHandler(err: unknown, _req: NextRequest) {
{ status: 400 },
);
} else if (err instanceof OpenAI.APIError) {
const { name, status, headers, message } = err;
return NextResponse.json({ name, status, headers, message }, { status });
const { name, status, message } = err;
return NextResponse.json(
{ error: { name, message } },
{ status: status ?? 500 },
);
} else {
let errorMessage = "Unknown error";
if ((err as Object).hasOwnProperty("message")) {
errorMessage = (err as Error).message;
} else if (err instanceof Error) {
errorMessage = (err as Object).toString();
}
return NextResponse.json(
{ error: { message: "Internal server error", error: errorMessage } },
Copy link
Copy Markdown
Contributor

@lemilonkh lemilonkh Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the idea here of not accidentally leaking database details (hoewever all of our DB structure etc. is available publicly in this repository), for now I would hold off on merging this though.
This information can be crucial for debugging and until we have Grafana fully set up on our prod environment we kind of rely on this to debug it.

Copy link
Copy Markdown
Contributor Author

@pablo-ibco pablo-ibco Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lemilonkh nice! Do we have on our roadmap when we plan to have Grafana fully set up or is it something being discussed yet?

{ error: { message: "Internal server error" } },
{ status: 500 },
);
}
Expand Down
Loading