fix: improve inventory mapping screen display values#2772
Merged
tatimoreira merged 2 commits intoJul 6, 2026
Conversation
lemilonkh
approved these changes
Jul 6, 2026
lemilonkh
left a comment
Contributor
There was a problem hiding this comment.
Amazing work, thanks 🙌 ✨
- Replace dash placeholder with "Not specified" in tertiary color for empty/undefined fields across validation, mapping, and review steps - Sort mapping columns so auto-detected fields appear first, grouping required fields together visually - Convert emission factor example values from raw units to metric tonnes (t CO2e) in both the validation results and mapping columns steps - Add followRegionRedirects to S3 client to handle bucket region mismatches - Add "not-specified" i18n key across all 5 supported locales (en, es, fr, de, pt)
tatimoreira
force-pushed
the
fix/ON-5985-Update-inventory-mapping-screen-values
branch
from
July 6, 2026 16:34
a639b63 to
d2fc2a6
Compare
tatimoreira
deleted the
fix/ON-5985-Update-inventory-mapping-screen-values
branch
July 6, 2026 16:51
This was referenced Jul 6, 2026
lemilonkh
pushed a commit
that referenced
this pull request
Jul 8, 2026
…2804) PR #2772 improved mapping-columns-step.tsx but that component was deleted by PR #2777 when the import flow was consolidated into InventoryMappingStep. Port the same fixes to the new component: - Convert emission factor example values (CO2/CH4/N2O/TotalCO2e) from raw units to metric tonnes (t CO2e) - Show "Not specified" in tertiary color instead of "-" for empty/undefined example values - Sort: required fields first, then auto-detected fields, then undetected, so Activity data amount and other mandatory fields group at the top
lemilonkh
pushed a commit
that referenced
this pull request
Jul 8, 2026
…2804) PR #2772 improved mapping-columns-step.tsx but that component was deleted by PR #2777 when the import flow was consolidated into InventoryMappingStep. Port the same fixes to the new component: - Convert emission factor example values (CO2/CH4/N2O/TotalCO2e) from raw units to metric tonnes (t CO2e) - Show "Not specified" in tertiary color instead of "-" for empty/undefined example values - Sort: required fields first, then auto-detected fields, then undetected, so Activity data amount and other mandatory fields group at the top
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the inventory mapping screen (upload flow) to display empty/undefined field values as "Not specified" in tertiary color instead of a bare dash, making it clear when a field is intentionally unspecified rather than an error. Also groups detected fields visually at the top of the mapping table, converts emission factor example values to metric tonnes (t CO₂e) for readability, and fixes an S3 PermanentRedirect error that prevented file uploads when the bucket's AWS region did not match the client's default.
Changes
How to test
Preview
Ticket
ON-5985
Notes
S3 redirect fix detail: the AWS SDK v3 S3 client by default treats a 301 PermanentRedirect response (returned when the bucket's region doesn't match the request endpoint) as a fatal error. Adding followRegionRedirects: true to the client config instructs the SDK to re-issue the request against the correct regional endpoint automatically. This means uploads work correctly even if AWS_FILE_UPLOAD_REGION is unset (defaults to us-east-1) or misconfigured — no change to environment variable setup is required for existing deployments.