fix(ui): port emission factor display fixes to InventoryMappingStep#2804
Merged
lemilonkh merged 1 commit intoJul 8, 2026
Merged
Conversation
…ryMappingStep PR #2772 improved mapping-columns-step.tsx but that component was deleted by PR #2777 when the import flow was consolidated into InventoryMappingStep. Port the same fixes to the new component: - Convert emission factor example values (CO2/CH4/N2O/TotalCO2e) from raw units to metric tonnes (t CO2e) - Show "Not specified" in tertiary color instead of "-" for empty/undefined example values - Sort: required fields first, then auto-detected fields, then undetected, so Activity data amount and other mandatory fields group at the top
lemilonkh
deleted the
fix/ON-5985-port-emission-factor-fix-to-new-mapping-step
branch
July 8, 2026 08:56
lemilonkh
pushed a commit
that referenced
this pull request
Jul 8, 2026
…2804) PR #2772 improved mapping-columns-step.tsx but that component was deleted by PR #2777 when the import flow was consolidated into InventoryMappingStep. Port the same fixes to the new component: - Convert emission factor example values (CO2/CH4/N2O/TotalCO2e) from raw units to metric tonnes (t CO2e) - Show "Not specified" in tertiary color instead of "-" for empty/undefined example values - Sort: required fields first, then auto-detected fields, then undetected, so Activity data amount and other mandatory fields group at the top
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #2772 improved example value display in the import mapping screen, but those fixes targeted
mapping-columns-step.tsxwhich was deleted by PR #2777 when the 4-step import flow was consolidated intoInventoryMappingStep. The new component was left with the originalcol.exampleValue || "-"raw display.EMISSION_FACTOR_KEYS+formatExampleValueto convert CO2/CH4/N2O/TotalCO2e emission factor example values from raw units to metric tonnes (e.g.63.1545→0.0632 t CO2e)"-"placeholder with"Not specified"incontent.tertiarycolor so empty fields are visually distinct from actual dataTest plan
/GHGI/onboarding/import/and upload a GHGI filet CO2eformat