Fixed Masked Connector End Issue#4
Open
dandunbar23 wants to merge 2 commits into
Open
Conversation
added 2 commits
December 27, 2023 11:15
…ns to use it. Also fixed a bug in Connector.java that masked the client side port on a connector build.
…existing elements in a cameo project.
Collaborator
Author
|
This updated PR adds functionality to enable interacting with existing elements by referencing their cameo ids (Reference Issue #5). Specifically, it looks at the parent relationship and checks whether the ID in the parent relationship refers to an existing element in Cameo. If so, it returns that element. Otherwise, it behaves as before. This enables things like adding stereotypes to an existing profile or adding value properties to an existing block. |
Collaborator
|
@dandunbar23 are you on openmbee slack? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes bug addressed in Issue #2 related to Binding Connectors being masked on the Client side connector. Looking at the code, supplier role and client role were implemented differently. I changed the client role to match the way supplier role was set, and the bug resolved itself.
There may be a reason from other use cases the keep the client side role the way it was. If so, we will need to implement some sort of if statement logic based on the connector type.
Also, I pulled the importXmlSysml action into its own method instead of nesting it in the action listener. This allows other plugins to use the public method.