Update timestamp methods

Author: Open-Markets-Initiative

Asx/Asx_AsxSecurities_Ntp_Itch_v1_05_Dissector.lua

@@ -2817,7 +2817,7 @@ asx_asxsecurities_ntp_itch_v1_05.timestamp.composite = function(buffer, offset,
   local range = buffer(offset, length)
   local nanoseconds = range:uint()
   local value = asx_asxsecurities_ntp_itch_v1_05.timestamp.translate(nanoseconds, stored_second)
-  local display = asx_asxsecurities_ntp_itch_v1_05.timestamp.display(nanoseconds, stored_second)
+  local display = asx_asxsecurities_ntp_itch_v1_05.timestamp.display(nanoseconds, stored_second, packet)
   parent = parent:add(omi_asx_asxsecurities_ntp_itch_v1_05.fields.timestamp, range, value, display)
 
   asx_asxsecurities_ntp_itch_v1_05.second.generated(stored_second, range, packet, parent)

Asx/Asx_AsxSecurities_T24_Itch_v1_13_Dissector.lua

@@ -2860,7 +2860,7 @@ asx_asxsecurities_t24_itch_v1_13.timestamp.composite = function(buffer, offset,
   local range = buffer(offset, length)
   local nanoseconds = range:uint()
   local value = asx_asxsecurities_t24_itch_v1_13.timestamp.translate(nanoseconds, stored_second)
-  local display = asx_asxsecurities_t24_itch_v1_13.timestamp.display(nanoseconds, stored_second)
+  local display = asx_asxsecurities_t24_itch_v1_13.timestamp.display(nanoseconds, stored_second, packet)
   parent = parent:add(omi_asx_asxsecurities_t24_itch_v1_13.fields.timestamp, range, value, display)
 
   asx_asxsecurities_t24_itch_v1_13.second.generated(stored_second, range, packet, parent)

Asx/Asx_AsxSecurities_Trade_Itch_v2_0_Dissector.lua

@@ -1765,7 +1765,7 @@ asx_asxsecurities_trade_itch_v2_0.timestamp.composite = function(buffer, offset,
   local range = buffer(offset, length)
   local nanoseconds = range:uint()
   local value = asx_asxsecurities_trade_itch_v2_0.timestamp.translate(nanoseconds, stored_second)
-  local display = asx_asxsecurities_trade_itch_v2_0.timestamp.display(nanoseconds, stored_second)
+  local display = asx_asxsecurities_trade_itch_v2_0.timestamp.display(nanoseconds, stored_second, packet)
   parent = parent:add(omi_asx_asxsecurities_trade_itch_v2_0.fields.timestamp, range, value, display)
 
   asx_asxsecurities_trade_itch_v2_0.second.generated(stored_second, range, packet, parent)

Asx/Asx_AsxSecurities_Trade_Itch_v3_1_Dissector.lua

@@ -1548,7 +1548,7 @@ asx_asxsecurities_trade_itch_v3_1.timestamp.composite = function(buffer, offset,
   local range = buffer(offset, length)
   local nanoseconds = range:uint()
   local value = asx_asxsecurities_trade_itch_v3_1.timestamp.translate(nanoseconds, stored_second)
-  local display = asx_asxsecurities_trade_itch_v3_1.timestamp.display(nanoseconds, stored_second)
+  local display = asx_asxsecurities_trade_itch_v3_1.timestamp.display(nanoseconds, stored_second, packet)
   parent = parent:add(omi_asx_asxsecurities_trade_itch_v3_1.fields.timestamp, range, value, display)
 
   asx_asxsecurities_trade_itch_v3_1.second.generated(stored_second, range, packet, parent)

Asx/Asx_AsxSecurities_Trade_Ouch_v2_0_Dissector.lua

@@ -1001,7 +1001,12 @@ end
 asx_asxsecurities_trade_ouch_v2_0.requested_sequence_number.dissect = function(buffer, offset, packet, parent)
   local length = asx_asxsecurities_trade_ouch_v2_0.requested_sequence_number.size
   local range = buffer(offset, length)
-  local value = range:string()
+  local value = tonumber(range:string())
+
+  if value == nil then
+    value =  "Not Applicable"
+  end
+
   local display = asx_asxsecurities_trade_ouch_v2_0.requested_sequence_number.display(value, buffer, offset, packet, parent)
 
   parent:add(omi_asx_asxsecurities_trade_ouch_v2_0.fields.requested_sequence_number, range, value, display)
@@ -2526,6 +2531,14 @@ asx_asxsecurities_trade_ouch_v2_0.payload.dissect = function(buffer, offset, pac
   if packet_type == "S" then
     return asx_asxsecurities_trade_ouch_v2_0.sequenced_data_packet.dissect(buffer, offset, packet, parent)
   end
+  -- Dissect Server Heartbeat Packet
+  if packet_type == "H" then
+    return offset
+  end
+  -- Dissect End Of Session Packet
+  if packet_type == "Z" then
+    return offset
+  end
   -- Dissect Login Request Packet
   if packet_type == "L" then
     return asx_asxsecurities_trade_ouch_v2_0.login_request_packet.dissect(buffer, offset, packet, parent)
@@ -2534,6 +2547,14 @@ asx_asxsecurities_trade_ouch_v2_0.payload.dissect = function(buffer, offset, pac
   if packet_type == "U" then
     return asx_asxsecurities_trade_ouch_v2_0.unsequenced_data_packet.dissect(buffer, offset, packet, parent)
   end
+  -- Dissect Client Heartbeat Packet
+  if packet_type == "R" then
+    return offset
+  end
+  -- Dissect Logout Request Packet
+  if packet_type == "O" then
+    return offset
+  end
 
   return offset
 end
@@ -2600,7 +2621,7 @@ asx_asxsecurities_trade_ouch_v2_0.soup_bin_tcp_packet.fields = function(buffer,
   -- Dependency element: Packet Type
   local packet_type = buffer(index - 1, 1):string()
 
-  -- Payload: Runtime Type with 6 branches
+  -- Payload: Runtime Type with 10 branches
   index = asx_asxsecurities_trade_ouch_v2_0.payload.dissect(buffer, index, packet, parent, packet_type)
 
   return index

Asx/Asx_AsxSecurities_Trade_Ouch_v3_6_Dissector.lua

@@ -1044,7 +1044,12 @@ end
 asx_asxsecurities_trade_ouch_v3_6.requested_sequence_number.dissect = function(buffer, offset, packet, parent)
   local length = asx_asxsecurities_trade_ouch_v3_6.requested_sequence_number.size
   local range = buffer(offset, length)
-  local value = range:string()
+  local value = tonumber(range:string())
+
+  if value == nil then
+    value =  "Not Applicable"
+  end
+
   local display = asx_asxsecurities_trade_ouch_v3_6.requested_sequence_number.display(value, buffer, offset, packet, parent)
 
   parent:add(omi_asx_asxsecurities_trade_ouch_v3_6.fields.requested_sequence_number, range, value, display)
@@ -2549,6 +2554,14 @@ asx_asxsecurities_trade_ouch_v3_6.payload.dissect = function(buffer, offset, pac
   if packet_type == "S" then
     return asx_asxsecurities_trade_ouch_v3_6.sequenced_data_packet.dissect(buffer, offset, packet, parent)
   end
+  -- Dissect Server Heartbeat Packet
+  if packet_type == "H" then
+    return offset
+  end
+  -- Dissect End Of Session Packet
+  if packet_type == "Z" then
+    return offset
+  end
   -- Dissect Login Request Packet
   if packet_type == "L" then
     return asx_asxsecurities_trade_ouch_v3_6.login_request_packet.dissect(buffer, offset, packet, parent)
@@ -2557,6 +2570,14 @@ asx_asxsecurities_trade_ouch_v3_6.payload.dissect = function(buffer, offset, pac
   if packet_type == "U" then
     return asx_asxsecurities_trade_ouch_v3_6.unsequenced_data_packet.dissect(buffer, offset, packet, parent)
   end
+  -- Dissect Client Heartbeat Packet
+  if packet_type == "R" then
+    return offset
+  end
+  -- Dissect Logout Request Packet
+  if packet_type == "O" then
+    return offset
+  end
 
   return offset
 end
@@ -2623,7 +2644,7 @@ asx_asxsecurities_trade_ouch_v3_6.soup_bin_tcp_packet.fields = function(buffer,
   -- Dependency element: Packet Type
   local packet_type = buffer(index - 1, 1):string()
 
-  -- Payload: Runtime Type with 6 branches
+  -- Payload: Runtime Type with 10 branches
   index = asx_asxsecurities_trade_ouch_v3_6.payload.dissect(buffer, index, packet, parent, packet_type)
 
   return index

Asx/ReadMe.md

@@ -9,8 +9,8 @@
 | [AsxSecurities][AsxSecurities.Exchange] | [T24][Asx.AsxSecurities.T24] | [Itch][Omi.Encoding.Itch] | [1.13][Asx.AsxSecurities.T24.Itch.v1.13.Dissector] | 7/15/2014 | 5615 | [Deprecated][Omi.Glossary.Status.Deprecated] | [Untested][Omi.Glossary.Testing.Untested] | [pdf][Asx.AsxSecurities.T24.Itch.v1.13.Pdf] |
 | [AsxSecurities][AsxSecurities.Exchange] | [Trade][Asx.AsxSecurities.Trade] | [Itch][Omi.Encoding.Itch] | [3.1][Asx.AsxSecurities.Trade.Itch.v3.1.Dissector] | 3/1/2023 | 3146 | [Active][Omi.Glossary.Status.Active] | [Untested][Omi.Glossary.Testing.Untested] | [url][Asx.AsxSecurities.Trade.Itch.v3.1.Url] - [pdf][Asx.AsxSecurities.Trade.Itch.v3.1.Pdf] |
 | [AsxSecurities][AsxSecurities.Exchange] | [Trade][Asx.AsxSecurities.Trade] | [Itch][Omi.Encoding.Itch] | [2.0][Asx.AsxSecurities.Trade.Itch.v2.0.Dissector] | 4/1/2015 | 3193 | [Deprecated][Omi.Glossary.Status.Deprecated] | [Untested][Omi.Glossary.Testing.Untested] | [pdf][Asx.AsxSecurities.Trade.Itch.v2.0.Pdf] |
-| [AsxSecurities][AsxSecurities.Exchange] | [Trade][Asx.AsxSecurities.Trade] | [Ouch][Omi.Encoding.Ouch] | [3.6][Asx.AsxSecurities.Trade.Ouch.v3.6.Dissector] | 2/1/2023 | 2774 | [Active][Omi.Glossary.Status.Active] | [Untested][Omi.Glossary.Testing.Untested] | [url][Asx.AsxSecurities.Trade.Ouch.v3.6.Url] - [pdf][Asx.AsxSecurities.Trade.Ouch.v3.6.Pdf] |
-| [AsxSecurities][AsxSecurities.Exchange] | [Trade][Asx.AsxSecurities.Trade] | [Ouch][Omi.Encoding.Ouch] | [2.0][Asx.AsxSecurities.Trade.Ouch.v2.0.Dissector] | 4/1/2015 | 2751 | [Deprecated][Omi.Glossary.Status.Deprecated] | [Untested][Omi.Glossary.Testing.Untested] | [pdf][Asx.AsxSecurities.Trade.Ouch.v2.0.Pdf] |
+| [AsxSecurities][AsxSecurities.Exchange] | [Trade][Asx.AsxSecurities.Trade] | [Ouch][Omi.Encoding.Ouch] | [3.6][Asx.AsxSecurities.Trade.Ouch.v3.6.Dissector] | 2/1/2023 | 2795 | [Active][Omi.Glossary.Status.Active] | [Untested][Omi.Glossary.Testing.Untested] | [url][Asx.AsxSecurities.Trade.Ouch.v3.6.Url] - [pdf][Asx.AsxSecurities.Trade.Ouch.v3.6.Pdf] |
+| [AsxSecurities][AsxSecurities.Exchange] | [Trade][Asx.AsxSecurities.Trade] | [Ouch][Omi.Encoding.Ouch] | [2.0][Asx.AsxSecurities.Trade.Ouch.v2.0.Dissector] | 4/1/2015 | 2772 | [Deprecated][Omi.Glossary.Status.Deprecated] | [Untested][Omi.Glossary.Testing.Untested] | [pdf][Asx.AsxSecurities.Trade.Ouch.v2.0.Pdf] |
 
 
 Asx: [website](https://www.asx.com.au "Go to Australian Securities Exchange")

Cboe/Cboe_ByxEquities_MulticastDepthOfBook_Pitch_v2_41_29_Dissector.lua

@@ -117,7 +117,7 @@ omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.prefs.show_message_inde
 
 -- Time Offset Display Preferences
 cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.time_offset_format = 2  -- 0=Raw, 1=TimeOfDay, 2=FullDateTime
-cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.utc_offset_hours = 5 -- Hours behind UTC (EST = 5, EDT = 4, UTC = 0)
+cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.utc_offset_hours = 5 -- Hours behind UTC (EST) for midnight calculation
 
 local time_offset_format_enum = {
   { 1, "Raw", 0 },
@@ -126,7 +126,7 @@ local time_offset_format_enum = {
 }
 
 omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.prefs.time_offset_format = Pref.enum("Time Offset Format", 2, "Time Offset display format", time_offset_format_enum, false)
-omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.prefs.utc_offset_hours = Pref.uint("UTC Offset (hours)", 5, "Hours behind UTC for midnight calculation (EST=5, EDT=4, UTC=0)")
+omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.prefs.utc_offset_hours = Pref.uint("UTC Offset (hours)", 5, "Hours behind UTC (EST) for midnight calculation")
 
 -- Handle changed preferences
 function omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.prefs_changed()
@@ -1217,14 +1217,14 @@ cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.timestamp.display = functio
   if cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.time_offset_format == 2 and packet then
     local capture_time = type(packet.abs_ts) == "number" and packet.abs_ts or packet.abs_ts:tonumber()
     local utc_offset_seconds = cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.utc_offset_hours * 3600
-    local local_midnight = math.floor((capture_time - utc_offset_seconds) / 86400) * 86400 + utc_offset_seconds
+    local local_midnight = math.floor((capture_time - utc_offset_seconds) / 86400) * 86400
     local full_seconds = local_midnight + stored_time
 
-    return "Timestamp: "..os.date("%Y-%m-%d %H:%M:%S.", full_seconds)..string.format("%09d", time_offset)
+    return "Timestamp: "..os.date("!%Y-%m-%d %H:%M:%S.", full_seconds)..string.format("%09d", time_offset)
   end
 
   -- Time of day mode
-  return "Timestamp: "..os.date("%H:%M:%S.", stored_time)..string.format("%09d", time_offset)
+  return "Timestamp: "..os.date("!%H:%M:%S.", stored_time)..string.format("%09d", time_offset)
 end
 
 -- Composite: Timestamp
@@ -1233,7 +1233,7 @@ cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.timestamp.composite = funct
   local range = buffer(offset, length)
   local time_offset = range:le_uint()
   local value = cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.timestamp.translate(time_offset, stored_time)
-  local display = cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.timestamp.display(time_offset, stored_time)
+  local display = cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.timestamp.display(time_offset, stored_time, packet)
   parent = parent:add(omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.fields.timestamp, range, value, display)
 
   cboe_byxequities_multicastdepthofbook_pitch_v2_41_29.time.generated(stored_time, range, packet, parent)

Cboe/Cboe_ByxEquities_MulticastDepthOfBook_Pitch_v2_41_64_Dissector.lua

@@ -118,7 +118,7 @@ omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.prefs.show_message_inde
 
 -- Time Offset Display Preferences
 cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.time_offset_format = 2  -- 0=Raw, 1=TimeOfDay, 2=FullDateTime
-cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.utc_offset_hours = 5 -- Hours behind UTC (EST = 5, EDT = 4, UTC = 0)
+cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.utc_offset_hours = 5 -- Hours behind UTC (EST) for midnight calculation
 
 local time_offset_format_enum = {
   { 1, "Raw", 0 },
@@ -127,7 +127,7 @@ local time_offset_format_enum = {
 }
 
 omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.prefs.time_offset_format = Pref.enum("Time Offset Format", 2, "Time Offset display format", time_offset_format_enum, false)
-omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.prefs.utc_offset_hours = Pref.uint("UTC Offset (hours)", 5, "Hours behind UTC for midnight calculation (EST=5, EDT=4, UTC=0)")
+omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.prefs.utc_offset_hours = Pref.uint("UTC Offset (hours)", 5, "Hours behind UTC (EST) for midnight calculation")
 
 -- Handle changed preferences
 function omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.prefs_changed()
@@ -1251,14 +1251,14 @@ cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.timestamp.display = functio
   if cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.time_offset_format == 2 and packet then
     local capture_time = type(packet.abs_ts) == "number" and packet.abs_ts or packet.abs_ts:tonumber()
     local utc_offset_seconds = cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.utc_offset_hours * 3600
-    local local_midnight = math.floor((capture_time - utc_offset_seconds) / 86400) * 86400 + utc_offset_seconds
+    local local_midnight = math.floor((capture_time - utc_offset_seconds) / 86400) * 86400
     local full_seconds = local_midnight + stored_time
 
-    return "Timestamp: "..os.date("%Y-%m-%d %H:%M:%S.", full_seconds)..string.format("%09d", time_offset)
+    return "Timestamp: "..os.date("!%Y-%m-%d %H:%M:%S.", full_seconds)..string.format("%09d", time_offset)
   end
 
   -- Time of day mode
-  return "Timestamp: "..os.date("%H:%M:%S.", stored_time)..string.format("%09d", time_offset)
+  return "Timestamp: "..os.date("!%H:%M:%S.", stored_time)..string.format("%09d", time_offset)
 end
 
 -- Composite: Timestamp
@@ -1267,7 +1267,7 @@ cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.timestamp.composite = funct
   local range = buffer(offset, length)
   local time_offset = range:le_uint()
   local value = cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.timestamp.translate(time_offset, stored_time)
-  local display = cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.timestamp.display(time_offset, stored_time)
+  local display = cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.timestamp.display(time_offset, stored_time, packet)
   parent = parent:add(omi_cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.fields.timestamp, range, value, display)
 
   cboe_byxequities_multicastdepthofbook_pitch_v2_41_64.time.generated(stored_time, range, packet, parent)

Cboe/Cboe_BzxEquities_MulticastDepthOfBook_Pitch_v2_41_29_Dissector.lua

@@ -115,7 +115,7 @@ omi_cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.prefs.show_message_inde
 
 -- Time Offset Display Preferences
 cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.time_offset_format = 2  -- 0=Raw, 1=TimeOfDay, 2=FullDateTime
-cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.utc_offset_hours = 5 -- Hours behind UTC (EST = 5, EDT = 4, UTC = 0)
+cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.utc_offset_hours = 5 -- Hours behind UTC (EST) for midnight calculation
 
 local time_offset_format_enum = {
   { 1, "Raw", 0 },
@@ -124,7 +124,7 @@ local time_offset_format_enum = {
 }
 
 omi_cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.prefs.time_offset_format = Pref.enum("Time Offset Format", 2, "Time Offset display format", time_offset_format_enum, false)
-omi_cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.prefs.utc_offset_hours = Pref.uint("UTC Offset (hours)", 5, "Hours behind UTC for midnight calculation (EST=5, EDT=4, UTC=0)")
+omi_cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.prefs.utc_offset_hours = Pref.uint("UTC Offset (hours)", 5, "Hours behind UTC (EST) for midnight calculation")
 
 -- Handle changed preferences
 function omi_cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.prefs_changed()
@@ -1176,14 +1176,14 @@ cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.timestamp.display = functio
   if cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.time_offset_format == 2 and packet then
     local capture_time = type(packet.abs_ts) == "number" and packet.abs_ts or packet.abs_ts:tonumber()
     local utc_offset_seconds = cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.utc_offset_hours * 3600
-    local local_midnight = math.floor((capture_time - utc_offset_seconds) / 86400) * 86400 + utc_offset_seconds
+    local local_midnight = math.floor((capture_time - utc_offset_seconds) / 86400) * 86400
     local full_seconds = local_midnight + stored_time
 
-    return "Timestamp: "..os.date("%Y-%m-%d %H:%M:%S.", full_seconds)..string.format("%09d", time_offset)
+    return "Timestamp: "..os.date("!%Y-%m-%d %H:%M:%S.", full_seconds)..string.format("%09d", time_offset)
   end
 
   -- Time of day mode
-  return "Timestamp: "..os.date("%H:%M:%S.", stored_time)..string.format("%09d", time_offset)
+  return "Timestamp: "..os.date("!%H:%M:%S.", stored_time)..string.format("%09d", time_offset)
 end
 
 -- Composite: Timestamp
@@ -1192,7 +1192,7 @@ cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.timestamp.composite = funct
   local range = buffer(offset, length)
   local time_offset = range:le_uint()
   local value = cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.timestamp.translate(time_offset, stored_time)
-  local display = cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.timestamp.display(time_offset, stored_time)
+  local display = cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.timestamp.display(time_offset, stored_time, packet)
   parent = parent:add(omi_cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.fields.timestamp, range, value, display)
 
   cboe_bzxequities_multicastdepthofbook_pitch_v2_41_29.time.generated(stored_time, range, packet, parent)