Skip to content

Commit cd242a0

Browse files
Open-Markets-InitiativeOpen-Markets-Initiative
committed
Fix invalid if statement in multitree protocols
1 parent 0a80238 commit cd242a0

3 files changed

Lines changed: 60 additions & 59 deletions

File tree

‎Jnx/Jnx_JnxEquities_Pts_Itch_v1_7_Dissector.lua‎

Lines changed: 58 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -2883,63 +2883,64 @@ function omi_jnx_jnxequities_pts_itch_v1_7.dissector(buffer, packet, parent)
28832883
local protocol = parent:add(omi_jnx_jnxequities_pts_itch_v1_7, buffer(), omi_jnx_jnxequities_pts_itch_v1_7.description, "("..buffer:len().." Bytes)")
28842884
if packet.port_type == 2 then
28852885
return jnx_jnxequities_pts_itch_v1_7.tcp_packet.dissect(buffer, packet, protocol)
2886-
if packet.port_type == 3 then
2887-
return jnx_jnxequities_pts_itch_v1_7.udp_packet.dissect(buffer, packet, protocol)
2888-
end
28892886
end
2887+
if packet.port_type == 3 then
2888+
return jnx_jnxequities_pts_itch_v1_7.udp_packet.dissect(buffer, packet, protocol)
2889+
end
2890+
end
2891+
2892+
2893+
-----------------------------------------------------------------------
2894+
-- Protocol Heuristics
2895+
-----------------------------------------------------------------------
2896+
2897+
-- Dissector Heuristic for Jnx JnxEquities Pts Itch 1.7 (Tcp)
2898+
local function omi_jnx_jnxequities_pts_itch_v1_7_tcp_heuristic(buffer, packet, parent)
2899+
-- Verify packet length
2900+
if not jnx_jnxequities_pts_itch_v1_7.tcp_packet.requiredsize(buffer) then return false end
2901+
2902+
-- Protocol is valid, set conversation and dissect this packet
2903+
packet.conversation = omi_jnx_jnxequities_pts_itch_v1_7
2904+
omi_jnx_jnxequities_pts_itch_v1_7.dissector(buffer, packet, parent)
2905+
2906+
return true
2907+
end
28902908

2909+
-- Dissector Heuristic for Jnx JnxEquities Pts Itch 1.7 (Udp)
2910+
local function omi_jnx_jnxequities_pts_itch_v1_7_udp_heuristic(buffer, packet, parent)
2911+
-- Verify packet length
2912+
if not jnx_jnxequities_pts_itch_v1_7.udp_packet.requiredsize(buffer) then return false end
28912913

2892-
-----------------------------------------------------------------------
2893-
-- Protocol Heuristics
2894-
-----------------------------------------------------------------------
2895-
2896-
-- Dissector Heuristic for Jnx JnxEquities Pts Itch 1.7 (Tcp)
2897-
local function omi_jnx_jnxequities_pts_itch_v1_7_tcp_heuristic(buffer, packet, parent)
2898-
-- Verify packet length
2899-
if not jnx_jnxequities_pts_itch_v1_7.tcp_packet.requiredsize(buffer) then return false end
2900-
2901-
-- Protocol is valid, set conversation and dissect this packet
2902-
packet.conversation = omi_jnx_jnxequities_pts_itch_v1_7
2903-
omi_jnx_jnxequities_pts_itch_v1_7.dissector(buffer, packet, parent)
2904-
2905-
return true
2906-
end
2907-
2908-
-- Dissector Heuristic for Jnx JnxEquities Pts Itch 1.7 (Udp)
2909-
local function omi_jnx_jnxequities_pts_itch_v1_7_udp_heuristic(buffer, packet, parent)
2910-
-- Verify packet length
2911-
if not jnx_jnxequities_pts_itch_v1_7.udp_packet.requiredsize(buffer) then return false end
2912-
2913-
-- Protocol is valid, set conversation and dissect this packet
2914-
packet.conversation = omi_jnx_jnxequities_pts_itch_v1_7
2915-
omi_jnx_jnxequities_pts_itch_v1_7.dissector(buffer, packet, parent)
2916-
2917-
return true
2918-
end
2919-
2920-
-- Register Heuristics for Jnx JnxEquities Pts Itch 1.7
2921-
omi_jnx_jnxequities_pts_itch_v1_7:register_heuristic("tcp", omi_jnx_jnxequities_pts_itch_v1_7_tcp_heuristic)
2922-
omi_jnx_jnxequities_pts_itch_v1_7:register_heuristic("udp", omi_jnx_jnxequities_pts_itch_v1_7_udp_heuristic)
2923-
2924-
-----------------------------------------------------------------------
2925-
-- Lua dissectors are an easily edited and modified cross-platform dissection solution.
2926-
-- Feel free to modify. Enjoy.
2927-
-----------------------------------------------------------------------
2928-
--
2929-
-- Protocol:
2930-
-- Organization: Japannext Securities (JNX)
2931-
-- Version: 1.7
2932-
-- Date: Wednesday, November 1, 2023
2933-
-- Specification: Japannext_PTS_ITCH_Equities_v1.7.pdf
2934-
--
2935-
-- Script:
2936-
-- Generator: 1.5.0.0
2937-
-- Compiler: 2.0
2938-
-- License: Public/GPLv3
2939-
-- Authors: Omi Developers
2940-
--
2941-
-- This dissector script was generated by The Open Markets Initiative (Omi).
2942-
--
2943-
-- For full Omi information:
2944-
-- https://github.com/Open-Markets-Initiative/Directory
2945-
-----------------------------------------------------------------------
2914+
-- Protocol is valid, set conversation and dissect this packet
2915+
packet.conversation = omi_jnx_jnxequities_pts_itch_v1_7
2916+
omi_jnx_jnxequities_pts_itch_v1_7.dissector(buffer, packet, parent)
2917+
2918+
return true
2919+
end
2920+
2921+
-- Register Heuristics for Jnx JnxEquities Pts Itch 1.7
2922+
omi_jnx_jnxequities_pts_itch_v1_7:register_heuristic("tcp", omi_jnx_jnxequities_pts_itch_v1_7_tcp_heuristic)
2923+
omi_jnx_jnxequities_pts_itch_v1_7:register_heuristic("udp", omi_jnx_jnxequities_pts_itch_v1_7_udp_heuristic)
2924+
2925+
-----------------------------------------------------------------------
2926+
-- Lua dissectors are an easily edited and modified cross-platform dissection solution.
2927+
-- Feel free to modify. Enjoy.
2928+
-----------------------------------------------------------------------
2929+
--
2930+
-- Protocol:
2931+
-- Organization: Japannext Securities (JNX)
2932+
-- Version: 1.7
2933+
-- Date: Wednesday, November 1, 2023
2934+
-- Specification: Japannext_PTS_ITCH_Equities_v1.7.pdf
2935+
--
2936+
-- Script:
2937+
-- Generator: 1.5.0.0
2938+
-- Compiler: 2.0
2939+
-- License: Public/GPLv3
2940+
-- Authors: Omi Developers
2941+
--
2942+
-- This dissector script was generated by The Open Markets Initiative (Omi).
2943+
--
2944+
-- For full Omi information:
2945+
-- https://github.com/Open-Markets-Initiative/Directory
2946+
-----------------------------------------------------------------------

‎Jnx/ReadMe.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
| [JnxBonds][JnxBonds.Exchange] | [Pts][Jnx.JnxBonds.Pts] | [Itch][Omi.Encoding.Itch] | [1.2][Jnx.JnxBonds.Pts.Itch.v1.2.Dissector] | 4/1/2020 | 1690 | [Active][Omi.Glossary.Status.Active] | [Untested][Omi.Glossary.Testing.Untested] | [url][Jnx.JnxBonds.Pts.Itch.v1.2.Url] - [pdf][Jnx.JnxBonds.Pts.Itch.v1.2.Pdf] |
99
| [JnxBonds][JnxBonds.Exchange] | [Pts][Jnx.JnxBonds.Pts] | [Ouch][Omi.Encoding.Ouch] | [1.4][Jnx.JnxBonds.Pts.Ouch.v1.4.Dissector] | 4/1/2020 | 2596 | [Active][Omi.Glossary.Status.Active] | [Untested][Omi.Glossary.Testing.Untested] | [url][Jnx.JnxBonds.Pts.Ouch.v1.4.Url] - [pdf][Jnx.JnxBonds.Pts.Ouch.v1.4.Pdf] |
1010
| [JnxEquities][JnxEquities.Exchange] | [Pts][Jnx.JnxEquities.Pts] | [Itch][Omi.Encoding.Itch] | [2.0][Jnx.JnxEquities.Pts.Itch.v2.0.Dissector] | 9/17/2025 | 1959 | [Active][Omi.Glossary.Status.Active] | [Untested][Omi.Glossary.Testing.Untested] | [url][Jnx.JnxEquities.Pts.Itch.v2.0.Url] - [pdf][Jnx.JnxEquities.Pts.Itch.v2.0.Pdf] |
11-
| [JnxEquities][JnxEquities.Exchange] | [Pts][Jnx.JnxEquities.Pts] | [Itch][Omi.Encoding.Itch] | [1.7][Jnx.JnxEquities.Pts.Itch.v1.7.Dissector] | 11/1/2023 | 2868 | [Future][Omi.Glossary.Status.Future] | [Verified][Omi.Glossary.Testing.Verified] | [url][Jnx.JnxEquities.Pts.Itch.v1.7.Url] - [pdf][Jnx.JnxEquities.Pts.Itch.v1.7.Pdf] |
11+
| [JnxEquities][JnxEquities.Exchange] | [Pts][Jnx.JnxEquities.Pts] | [Itch][Omi.Encoding.Itch] | [1.7][Jnx.JnxEquities.Pts.Itch.v1.7.Dissector] | 11/1/2023 | 2869 | [Future][Omi.Glossary.Status.Future] | [Verified][Omi.Glossary.Testing.Verified] | [url][Jnx.JnxEquities.Pts.Itch.v1.7.Url] - [pdf][Jnx.JnxEquities.Pts.Itch.v1.7.Pdf] |
1212
| [JnxEquities][JnxEquities.Exchange] | [Pts][Jnx.JnxEquities.Pts] | [Itch][Omi.Encoding.Itch] | [1.6][Jnx.JnxEquities.Pts.Itch.v1.6.Dissector] | 3/9/2023 | 1940 | [Active][Omi.Glossary.Status.Active] | [Verified][Omi.Glossary.Testing.Verified] | [url][Jnx.JnxEquities.Pts.Itch.v1.6.Url] - [pdf][Jnx.JnxEquities.Pts.Itch.v1.6.Pdf] |
1313
| [JnxEquities][JnxEquities.Exchange] | [Pts][Jnx.JnxEquities.Pts] | [Ouch][Omi.Encoding.Ouch] | [1.12][Jnx.JnxEquities.Pts.Ouch.v1.12.Dissector] | 11/1/2023 | 2604 | [Active][Omi.Glossary.Status.Active] | [Verified][Omi.Glossary.Testing.Verified] | [url][Jnx.JnxEquities.Pts.Ouch.v1.12.Url] - [pdf][Jnx.JnxEquities.Pts.Ouch.v1.12.Pdf] |
1414
| [JnxEquities][JnxEquities.Exchange] | [Pts][Jnx.JnxEquities.Pts] | [Ouch][Omi.Encoding.Ouch] | [1.11][Jnx.JnxEquities.Pts.Ouch.v1.11.Dissector] | 3/9/2023 | 2604 | [Deprecated][Omi.Glossary.Status.Deprecated] | [Untested][Omi.Glossary.Testing.Untested] | [url][Jnx.JnxEquities.Pts.Ouch.v1.11.Url] - [pdf][Jnx.JnxEquities.Pts.Ouch.v1.11.Pdf] |

‎ReadMe.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Updates are greatly appreciated; however, this entire repository is source gener
3232

3333
| Protocol Count | Generated Lines |
3434
| --- | --- |
35-
| 521 | 4,489,993 |
35+
| 521 | 4,489,994 |
3636

3737
## Testing
3838

0 commit comments

Comments
 (0)