Skip to content

Commit 776ae7b

Browse files
Inspecition fixes and reformat.
1 parent d910b9e commit 776ae7b

21 files changed

+468
-173
lines changed

.editorconfig

Lines changed: 219 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,219 @@
1+
# Remove the line below if you want to inherit .editorconfig settings from higher directories
2+
root = true
3+
4+
# C# files
5+
[*.cs]
6+
7+
#### Core EditorConfig Options ####
8+
9+
# Indentation and spacing
10+
indent_size = 4
11+
indent_style = tab
12+
tab_width = 4
13+
14+
# New line preferences
15+
end_of_line = crlf
16+
insert_final_newline = false
17+
18+
#### .NET Coding Conventions ####
19+
20+
# Organize usings
21+
dotnet_separate_import_directive_groups = false
22+
dotnet_sort_system_directives_first = false
23+
file_header_template = unset
24+
25+
# this. and Me. preferences
26+
dotnet_style_qualification_for_event = false:suggestion
27+
dotnet_style_qualification_for_field = false
28+
dotnet_style_qualification_for_method = false:suggestion
29+
dotnet_style_qualification_for_property = false:suggestion
30+
31+
# Language keywords vs BCL types preferences
32+
dotnet_style_predefined_type_for_locals_parameters_members = true:warning
33+
dotnet_style_predefined_type_for_member_access = true:warning
34+
35+
# Parentheses preferences
36+
dotnet_style_parentheses_in_arithmetic_binary_operators = never_if_unnecessary:suggestion
37+
dotnet_style_parentheses_in_other_binary_operators = never_if_unnecessary:suggestion
38+
dotnet_style_parentheses_in_other_operators = never_if_unnecessary:suggestion
39+
dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:suggestion
40+
41+
# Modifier preferences
42+
dotnet_style_require_accessibility_modifiers = for_non_interface_members
43+
44+
# Expression-level preferences
45+
dotnet_style_coalesce_expression = true:warning
46+
dotnet_style_collection_initializer = true
47+
dotnet_style_explicit_tuple_names = true
48+
dotnet_style_namespace_match_folder = true
49+
dotnet_style_null_propagation = true:warning
50+
dotnet_style_object_initializer = true
51+
dotnet_style_operator_placement_when_wrapping = beginning_of_line
52+
dotnet_style_prefer_auto_properties = true:suggestion
53+
dotnet_style_prefer_compound_assignment = true
54+
dotnet_style_prefer_conditional_expression_over_assignment = true:warning
55+
dotnet_style_prefer_conditional_expression_over_return = true:warning
56+
dotnet_style_prefer_inferred_anonymous_type_member_names = true
57+
dotnet_style_prefer_inferred_tuple_names = true
58+
dotnet_style_prefer_is_null_check_over_reference_equality_method = true:warning
59+
dotnet_style_prefer_simplified_boolean_expressions = true:warning
60+
dotnet_style_prefer_simplified_interpolation = true
61+
62+
# Field preferences
63+
dotnet_style_readonly_field = true
64+
65+
# Parameter preferences
66+
dotnet_code_quality_unused_parameters = all
67+
68+
# Suppression preferences
69+
dotnet_remove_unnecessary_suppression_exclusions = none
70+
71+
# New line preferences
72+
dotnet_style_allow_multiple_blank_lines_experimental = true
73+
dotnet_style_allow_statement_immediately_after_block_experimental = false
74+
75+
#### C# Coding Conventions ####
76+
77+
# var preferences
78+
csharp_style_var_elsewhere = false
79+
csharp_style_var_for_built_in_types = false
80+
csharp_style_var_when_type_is_apparent = true:suggestion
81+
82+
# Expression-bodied members
83+
csharp_style_expression_bodied_accessors = true:suggestion
84+
csharp_style_expression_bodied_constructors = when_on_single_line
85+
csharp_style_expression_bodied_indexers = true:suggestion
86+
csharp_style_expression_bodied_lambdas = true:suggestion
87+
csharp_style_expression_bodied_local_functions = true:suggestion
88+
csharp_style_expression_bodied_methods = true:suggestion
89+
csharp_style_expression_bodied_operators = true:suggestion
90+
csharp_style_expression_bodied_properties = true:suggestion
91+
92+
# Pattern matching preferences
93+
csharp_style_pattern_matching_over_as_with_null_check = true:warning
94+
csharp_style_pattern_matching_over_is_with_cast_check = true:warning
95+
csharp_style_prefer_not_pattern = true:warning
96+
csharp_style_prefer_pattern_matching = true:suggestion
97+
csharp_style_prefer_switch_expression = true
98+
99+
# Null-checking preferences
100+
csharp_style_conditional_delegate_call = true:warning
101+
102+
# Modifier preferences
103+
csharp_prefer_static_local_function = true
104+
csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async
105+
106+
# Code-block preferences
107+
csharp_prefer_braces = when_multiline
108+
csharp_prefer_simple_using_statement = true
109+
csharp_style_namespace_declarations = file_scoped:suggestion
110+
111+
# Expression-level preferences
112+
csharp_prefer_simple_default_expression = true
113+
csharp_style_deconstructed_variable_declaration = true
114+
csharp_style_implicit_object_creation_when_type_is_apparent = true
115+
csharp_style_inlined_variable_declaration = true
116+
csharp_style_pattern_local_over_anonymous_function = true
117+
csharp_style_prefer_index_operator = true:silent
118+
csharp_style_prefer_null_check_over_type_check = true:warning
119+
csharp_style_prefer_range_operator = true:silent
120+
csharp_style_throw_expression = true:warning
121+
csharp_style_unused_value_assignment_preference = discard_variable
122+
csharp_style_unused_value_expression_statement_preference = discard_variable
123+
124+
# 'using' directive preferences
125+
csharp_using_directive_placement = outside_namespace:warning
126+
127+
# New line preferences
128+
csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = false:warning
129+
csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true
130+
csharp_style_allow_embedded_statements_on_same_line_experimental = true
131+
132+
#### C# Formatting Rules ####
133+
134+
# New line preferences
135+
csharp_new_line_before_catch = true
136+
csharp_new_line_before_else = true
137+
csharp_new_line_before_finally = true
138+
csharp_new_line_before_members_in_anonymous_types = true
139+
csharp_new_line_before_members_in_object_initializers = true
140+
csharp_new_line_before_open_brace = all
141+
csharp_new_line_between_query_expression_clauses = true
142+
143+
# Indentation preferences
144+
csharp_indent_block_contents = true
145+
csharp_indent_braces = false
146+
csharp_indent_case_contents = true
147+
csharp_indent_case_contents_when_block = true
148+
csharp_indent_labels = one_less_than_current
149+
csharp_indent_switch_labels = true
150+
151+
# Space preferences
152+
csharp_space_after_cast = false
153+
csharp_space_after_colon_in_inheritance_clause = true
154+
csharp_space_after_comma = true
155+
csharp_space_after_dot = false
156+
csharp_space_after_keywords_in_control_flow_statements = true
157+
csharp_space_after_semicolon_in_for_statement = true
158+
csharp_space_around_binary_operators = before_and_after
159+
csharp_space_around_declaration_statements = false
160+
csharp_space_before_colon_in_inheritance_clause = true
161+
csharp_space_before_comma = false
162+
csharp_space_before_dot = false
163+
csharp_space_before_open_square_brackets = false
164+
csharp_space_before_semicolon_in_for_statement = false
165+
csharp_space_between_empty_square_brackets = false
166+
csharp_space_between_method_call_empty_parameter_list_parentheses = false
167+
csharp_space_between_method_call_name_and_opening_parenthesis = false
168+
csharp_space_between_method_call_parameter_list_parentheses = false
169+
csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
170+
csharp_space_between_method_declaration_name_and_open_parenthesis = false
171+
csharp_space_between_method_declaration_parameter_list_parentheses = false
172+
csharp_space_between_parentheses = false
173+
csharp_space_between_square_brackets = false
174+
175+
# Wrapping preferences
176+
csharp_preserve_single_line_blocks = true
177+
csharp_preserve_single_line_statements = true
178+
179+
#### Naming styles ####
180+
181+
# Naming rules
182+
183+
dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
184+
dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
185+
dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
186+
187+
dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
188+
dotnet_naming_rule.types_should_be_pascal_case.symbols = types
189+
dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
190+
191+
dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
192+
dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
193+
dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
194+
195+
# Symbol specifications
196+
197+
dotnet_naming_symbols.interface.applicable_kinds = interface
198+
dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
199+
dotnet_naming_symbols.interface.required_modifiers =
200+
201+
dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
202+
dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
203+
dotnet_naming_symbols.types.required_modifiers =
204+
205+
dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
206+
dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
207+
dotnet_naming_symbols.non_field_members.required_modifiers =
208+
209+
# Naming styles
210+
211+
dotnet_naming_style.pascal_case.required_prefix =
212+
dotnet_naming_style.pascal_case.required_suffix =
213+
dotnet_naming_style.pascal_case.word_separator =
214+
dotnet_naming_style.pascal_case.capitalization = pascal_case
215+
216+
dotnet_naming_style.begins_with_i.required_prefix = I
217+
dotnet_naming_style.begins_with_i.required_suffix =
218+
dotnet_naming_style.begins_with_i.word_separator =
219+
dotnet_naming_style.begins_with_i.capitalization = pascal_case

Open.ChannelExtensions.ComparisonTests/Program.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ static async Task Main()
1919
Console.WriteLine("Standard DataFlow operation test...");
2020
var block = new ActionBlock<int>(async i => await Delay(i));
2121
var sw = Stopwatch.StartNew();
22-
foreach (var i in Enumerable.Range(0, repeat))
22+
foreach (int i in Enumerable.Range(0, repeat))
2323
block.Post(i);
2424
block.Complete();
2525
await block.Completion;
@@ -35,12 +35,12 @@ static async Task Main()
3535

3636
{
3737
Console.WriteLine("Standard Channel filter test...");
38-
var source = Enumerable
38+
System.Collections.Generic.IEnumerable<ValueTask<int>> source = Enumerable
3939
.Repeat((Func<int, ValueTask<int>>)Delay, repeat)
4040
.Select((t, i) => t(i));
4141

4242
var sw = Stopwatch.StartNew();
43-
var total = await source
43+
long total = await source
4444
.ToChannelAsync(singleReader: true)
4545
.Filter(i => i % 2 == 0)
4646
.ReadAll(Dummy);
@@ -55,7 +55,7 @@ static async Task Main()
5555
Console.WriteLine("Concurrent DataFlow operation test...");
5656
var sw = Stopwatch.StartNew();
5757
var block = new ActionBlock<int>(async i => await Delay(i), new ExecutionDataflowBlockOptions { MaxDegreeOfParallelism = concurrency });
58-
foreach (var i in Enumerable.Range(0, repeat))
58+
foreach (int i in Enumerable.Range(0, repeat))
5959
block.Post(i);
6060
block.Complete();
6161
await block.Completion;
@@ -80,7 +80,7 @@ await Enumerable
8080
{
8181
Console.WriteLine("Pipe operation test...");
8282
var sw = Stopwatch.StartNew();
83-
var total = await Enumerable
83+
long total = await Enumerable
8484
.Repeat((Func<int, ValueTask<int>>)Delay, repeat)
8585
.Select((t, i) => t(i))
8686
.ToChannelAsync()

0 commit comments

Comments
 (0)