Skip to content

Commit a355fe2

Browse files
Analysis tweaks.
1 parent 96a2f77 commit a355fe2

File tree

3 files changed

+1
-2
lines changed

3 files changed

+1
-2
lines changed

Open.ChannelExtensions.Tests/BasicTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ public static class BasicTests
1616
[Theory]
1717
[InlineData(testSize1)]
1818
[InlineData(testSize2)]
19+
[System.Diagnostics.CodeAnalysis.SuppressMessage("Reliability", "CA2012:Use ValueTasks correctly", Justification = "Testing onlly.")]
1920
public static async Task DeferredWriteRead(int testSize)
2021
{
2122
var range = Enumerable.Range(0, testSize);

Open.ChannelExtensions/Extensions.ReadConcurrently.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ public static partial class Extensions
1818
/// <param name="receiver">The async receiver function.</param>
1919
/// <param name="cancellationToken">An optional cancellation token.</param>
2020
/// <returns>A task that completes when no more reading is to be done.</returns>
21-
[System.Diagnostics.CodeAnalysis.SuppressMessage("Reliability", "CA2000:Dispose objects before losing scope", Justification = "Async scope.")]
2221
public static Task<long> ReadAllConcurrentlyAsync<T>(this ChannelReader<T> reader,
2322
int maxConcurrency,
2423
Func<T, ValueTask> receiver,

Open.ChannelExtensions/Extensions.WriteConcurrently.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ public static partial class Extensions
2222
/// <returns>A task containing the count of items written that completes when all the data has been written to the channel writer.
2323
/// The count should be ignored if the number of iterations could exceed the max value of long.</returns>
2424

25-
[System.Diagnostics.CodeAnalysis.SuppressMessage("Reliability", "CA2000:Dispose objects before losing scope", Justification = "Async scope.")]
2625
public static Task<long> WriteAllConcurrentlyAsync<T>(this ChannelWriter<T> target,
2726
int maxConcurrency, IEnumerable<ValueTask<T>> source, bool complete = false, CancellationToken cancellationToken = default)
2827
{

0 commit comments

Comments
 (0)