gfx: fix drawing bugs in drawFrame and fillCircleAA#439
Open
markmentovai wants to merge 2 commits into
Open
Conversation
Graphics2D::drawFrame was drawing the right and bottom edges of frames (unfilled rectangles) one pixel too far to the right and below the correct location, and was leaving the bottom-right pixel where those misplaced line segments met untouched. These two line segments were being drawn at (x + w, …) and (…, y + h) instead of (x + w - 1, …) and (…, y + h - 1).
Graphics2D::fillCircleAA was omitting the center pixel from circles that it drew. The stroke thickness was one pixel less than a circle’s radius leaving a “hole” at each circle’s center, when it was supposed to be filled completely. The stroke thickness needs to be the full size of a circle’s radius in order to ensure that the circle is filled completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graphics2D::drawFrameandGraphics2D::fillCircleAAwere affected by distinct off-by-one errors that were causing them to draw unfilled rectangles and filled anti-aliased circles incorrectly.