typing: graduate the extract test domain out of the mypy baseline

[JSv4]

Summary

Continues the mypy baseline drain tracked in #1738 (the #1331 → #1335 → #1447 cadence). After the config tail (#1748), the tests.permissioning.* subpackage (#1768), and the annotation (#1776) / document (#1851) / corpus (#1866) / agent (#1877) leaf-file chunks, this is the next cohesive batch from the issue's tests.* batching plan (corpus / document / annotation / agent / extract / misc): the extract domain.

Removes the 6 [mypy-opencontractserver.tests.test_*] ignore_errors blocks for the structured-data-extraction feature — Extracts plus their Fieldsets/Columns, Datacells, and metadata columns (all defined in opencontractserver/extracts/models.py):

• test_extract_mutations
• test_extract_queries
• test_extract_tasks
• test_datacell_mutations
• test_column_mutations
• test_metadata_columns_graphql

Prunes the corresponding 57 lines from docs/typing/mypy_baseline.txt (3648 → 3591) and fixes the 42 errors that surface.

How

Every surfaced error was the same one: a graphene.test.Client assigned to self.client shadows the inherited django.test.TestCase.client, which has no .execute() (mypy resolves self.client.execute(...) through Django's client → [attr-defined]). The established fix from the prior chunks (#1776 / #1851 / #1866 / #1877) applies cleanly:

• self.client → self.graphene_client rename in the 5 GraphQL test modules. This is behaviour-equivalent: the assignment already shadowed Django's TestCase.client at runtime, every read in these files was .execute(), and no other module subclasses these test classes (verified). The rename is uniform — no other self.client usage (no real Django .get/.post/.force_login) exists in any of the files.
• test_extract_tasks needed no code change — only block removal + baseline pruning. Its historical set_permissions_for_obj_to_user arg-type errors no longer reproduce under django-stubs==6.0.5 (the same observation typing: graduate tests.test_annotation_* chunk out of mypy baseline #1776 / typing: graduate tests.test_document_* chunk out of the mypy baseline #1851 / typing: graduate tests.test_agent* chunk out of the mypy baseline #1877 made for the other chunks).

All changes are type-level. No production code is modified; no test assertions or logic change.

Test plan

• mypy --config-file mypy.ini opencontractserver config → Success: no issues found in 1263 source files, run in a venv mirroring the .pre-commit-config.yaml pin set, under both pinned toolchains:
  • mypy==2.0.0 / django-stubs==6.0.5 (pre-commit)
  • mypy==2.1.0 / django-stubs==6.0.5 (CI requirements/local.txt)
• pyupgrade --py39-plus / black==26.1.0 / isort==6.0.1 / flake8==7.2.0 (+flake8-isort) clean on all 6 files; trailing-whitespace / EOF hooks clean on mypy.ini, the baseline, and the changelog fragment.
• All 6 modules py_compile cleanly; renamed test classes have no external subclassers.
• scripts/collate_changelog.py --check passes (added changelog.d/1738-extract-tests-mypy.changed.md).
• Backend CI (backend.yml linter + test jobs) — the authoritative runtime check.

Note on local testing: the Dockerized backend suite could not be exercised in the authoring container (the Docker daemon is unavailable — no /var/run/docker.sock), matching the prior #1738 chunks. mypy was run via a venv mirroring the pre-commit pin set. The changes are behaviour-neutral (a self-contained instance-attribute rename, validated by mypy under both pins + py_compile + a no-external-subclassers check), so CI's backend job is relied on for the runtime check.

Refs #1738

https://claude.ai/code/session_01EF8XiHoMM2PPb7zxjEn7KU

---

Generated by Claude Code

[claude]

Code Review — PR #1924: Graduate the extract test domain out of the mypy baseline

Overview: This is the next installment in the mypy baseline drain (#1738), graduating 6 extract-domain test modules out of ignore_errors coverage. The fix is mechanically uniform: rename self.client (a graphene.test.Client) to self.graphene_client to stop shadowing django.test.TestCase.client, eliminating all 42 surfaced [attr-defined] errors. No production code is modified.

---

What's Good

• Correct and complete rename. Every self.client assignment in setUp and every subsequent .execute() call across all 5 files is consistently updated. No stray self.client references remain.
• Behaviour-equivalent change. The graphene.test.Client already fully shadowed Django's test client at runtime in these classes; no test used .get/.post/.force_login or any Django-client method. The rename is a pure type-level fix.
• Consistent with established pattern. The same approach was used in chunks typing: graduate tests.test_annotation_* chunk out of mypy baseline #1776 / typing: graduate tests.test_document_* chunk out of the mypy baseline #1851 / typing: graduate tests.test_corpus_* chunk out of the mypy baseline #1866 / typing: graduate tests.test_agent* chunk out of the mypy baseline #1877. Applying it uniformly here is correct.
• Baseline pruning is exact. The 57 lines removed from mypy_baseline.txt correspond precisely to the 6 modules being graduated.
• mypy.ini commentary is useful. Adding the prose block to the header explaining what Continue draining the mypy baseline established in #1331 — test suite + config tail #1738 graduated (and why) makes the residual ignore_errors blocks easier to understand in future review.
• Changelog fragment follows convention. Correct slug, correct .changed.md type, proper content.
• test_extract_tasks no-op removal is correctly explained. The historical arg-type errors for set_permissions_for_obj_to_user silently resolved under django-stubs==6.0.5; the PR documents this clearly, consistent with the same observation in prior chunks.

---

Minor Observations (non-blocking)

1. No explicit type annotation for self.graphene_client. The attribute could be annotated self.graphene_client: Client in setUp (or as a class-level annotation) to make mypy's inference explicit. This is not required — the rename alone clears the errors — and prior chunks didn't add annotations either, so this is consistent. Worth a future-pass consideration once the full batch is done.

2. Black reformatting on one call in test_extract_queries.py. One call was split across lines after the longer attribute name pushed it past the line-length limit. This is correct formatting; just confirming it's intentional rather than a semantic change.

3. No Docker CI run locally. The PR is transparent about this. The change is a pure rename with no logic delta, so backend CI is the authoritative gate — acceptable given the track record of prior identical chunks all passing CI.

---

Summary

Clean, low-risk PR with no issues to block merge. The change is behaviour-neutral, fully consistent with the pattern established across prior #1738 chunks, and correctly documented. Approving pending backend CI green.

[claude]

Graduates the extract test domain (6 modules) out of the mypy baseline - see full review below.

[claude]

Code Review - PR 1924: Graduate extract test domain out of mypy baseline

Overview

Graduates 6 test modules (test_extract_mutations, test_extract_queries, test_extract_tasks, test_datacell_mutations, test_column_mutations, test_metadata_columns_graphql) out of the mypy baseline as part of the ongoing 1738 drain. Root cause was a graphene.test.Client assigned to self.client shadowing django.test.TestCase.client (no .execute()). Fixed by renaming self.client -> self.graphene_client uniformly across 5 files. test_extract_tasks needed no code change.

Code Quality

Consistent with established pattern - identical rename approach to prior 1738 chunks (1776, 1851, 1866, 1877). Same root cause, same fix, correctly applied.

Rename is genuinely behavior-equivalent: self.client was already shadowing the Django test client at runtime; every read was .execute(). The rename also eliminates a latent footgun - a future self.client.get() call would silently hit the graphene client at runtime, but mypy now catches it.

Baseline pruning is accurate: 57 lines removed from docs/typing/mypy_baseline.txt exactly match the 6 graduated modules.

mypy.ini comment block properly updated with the new graduates, keeping the audit trail intact.

test_extract_tasks silent graduation is correctly explained: the prior set_permissions_for_obj_to_user arg-type errors no longer reproducing under django-stubs==6.0.5 is consistent with prior chunks - improved stubs, not a suppression.

Changelog fragment follows project conventions (changelog.d/1738-extract-tests-mypy.changed.md, changed type, no section headers).

Potential Issues

Minor: one cosmetic reformat in test_extract_queries.py at test_full_datacell_list_no_args_capped_at_server_max splits a single-line execute() call to two lines. Harmless, consistent with black, but an incidental diff.

CI is the runtime gate: Docker was unavailable during authoring, so no actual test run was performed. Pure attribute rename with no logic delta - risk is low, but CI backend job is the authoritative check.

No issues with test_extract_tasks block removal: removing ignore_errors = True that no longer matches any errors is strictly correct.

Summary

Clean, low-risk, mechanical maintenance PR that follows the established mypy drain pattern exactly. Rename is correctly scoped, baseline pruning is accurate, documentation is up to date. No concerns beyond the standard CI dependency for runtime verification.