Limit chunked ingest chord fan-out to respect parser concurrency limits#2087
Open
JSv4 wants to merge 2 commits into
Open
Limit chunked ingest chord fan-out to respect parser concurrency limits#2087JSv4 wants to merge 2 commits into
JSv4 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…-unbounded-chunk-processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
max_concurrent_chunksthrottling, allowing an authenticated uploader to enqueue an unbounded number of chunk tasks and impact availability.Description
chordwhenlen(chunk_inputs) <= parser_instance.max_concurrent_chunksinopencontractserver/tasks/doc_tasks.py.max_concurrent_chunks, fall back to the existing in-processprocess_documentpath so the synchronous dispatcher and its thread-pool throttling still control parser-service concurrency.test_ingest_doc_large_pdf_falls_back_when_chunk_count_exceeds_limitinopencontractserver/tests/test_chunk_tasks.pythat asserts oversized chunk sets do not callself.replace(...)/ dispatch a chord and instead use the synchronous path.Testing
python -m py_compile opencontractserver/tasks/doc_tasks.py opencontractserver/tests/test_chunk_tasks.py(succeeded).python manage.py test opencontractserver.tests.test_chunk_tasks --keepdb(blocked in this environment due to missingdjangodependency, so tests could not be executed end-to-end here).Codex Task