ci: fix clippy cold-cache v8 link failure; trim release gate to tests

- ci.yml: build before clippy so the v8 crate fetches its prebuilt static lib
  (clippy runs in check mode and won't download it on a cold Actions cache;
  deps build with normal rustc, so clippy reuses the artifact)
- release.yml: release gate runs only the tests (fmt/clippy are gated on main
  by ci.yml; tags are cut from main)
- release.sh: order the local gate fmt -> test -> clippy so the test build
  fetches v8 before clippy runs on a cold tree

Author: Thanga-Ganapathy

.github/workflows/ci.yml

@@ -34,6 +34,11 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: Swatinem/rust-cache@v2
+      # Build first so the `v8` crate fetches its prebuilt static lib. Clippy
+      # runs in check mode, which doesn't trigger that download on a cold cache;
+      # deps build with normal rustc (only workspace crates use clippy-driver),
+      # so clippy then reuses the v8 artifact.
+      - run: cargo build --workspace --all-features
       - run: cargo clippy --workspace --all-targets --all-features -- -D warnings
 
   test:

.github/workflows/release.yml

@@ -31,10 +31,8 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: Swatinem/rust-cache@v2
-      - name: Format
-        run: cargo fmt --all --check
-      - name: Clippy
-        run: cargo clippy --workspace --all-targets --locked -- -D warnings
+      # fmt/clippy are gated on main by ci.yml; the release only needs the tests
+      # to pass before artifacts publish.
       - name: Tests
         run: cargo test --workspace --locked
 

scripts/release.sh

@@ -33,17 +33,20 @@ err() { red "error: $*"; exit 1; }
 git diff --quiet && git diff --cached --quiet || err "working tree is dirty — commit or stash first"
 
 # --- local quality gate (before touching anything) -------------------------
-# CI re-runs all of this after the tag is pushed, but verify locally first so a
-# release is never started on code that doesn't format, lint, or test clean.
-# `cargo test --workspace` includes the CLI end-to-end test
-# (crates/runtime-cli/tests) that spawns the real `esrun` binary.
-# Reuses the existing target/ cache (no clean) — incremental on a warm tree.
-# A cold tree is slow once (downloads/links the prebuilt V8 static lib).
-bold "Running fmt, clippy, and the full test suite…"
+# Verify locally first so a release is never started on code that doesn't
+# format, test, or lint clean. `cargo test --workspace` includes the CLI
+# end-to-end test (crates/runtime-cli/tests) that spawns the real `esrun`.
+# Reuses the existing target/ cache (no clean) — incremental on a warm tree;
+# a cold tree is slow once (downloads/links the prebuilt V8 static lib).
+#
+# Order matters: tests compile + link (which fetches the v8 prebuilt lib), so
+# they run before clippy — clippy runs in check mode and won't fetch it on a
+# cold tree.
+bold "Running fmt, the full test suite, and clippy…"
 cargo fmt --all --check || err "formatting check failed — run 'cargo fmt' and retry"
+cargo test --workspace --locked || err "tests failed — fix them and retry"
 cargo clippy --workspace --all-targets --locked -- -D warnings ||
   err "clippy failed — fix the warnings and retry"
-cargo test --workspace --locked || err "tests failed — fix them and retry"
 
 branch="$(git rev-parse --abbrev-ref HEAD)"