Commit 2f69a62
committed
fix(render): Type1 font text rendering via system-font fallback (v1.47.10)
Symptom: PDFs with Type1 fonts (e.g. UniviaProRegular in Word/InDesign-
exported documents) rendered with all text invisible. Logos, vectors and
"-" bullets did appear, but glyph-encoded text was silently dropped.
Root cause:
- fonts.rs:287-308 extract_and_parse_font only checked /FontFile2
(TrueType) and /FontFile3 (CFF). The /FontFile (Type1 binary) stream
was ignored, leaving parsed=None.
- fonts.rs:367-388 try_system_font fell through if no system font matched
the BaseFont name (subset prefixes like BAAAAA+UniviaProRegular rarely
match).
- text_renderer.rs:46-49 early-returns when parsed=None, so no glyph fill
commands were emitted by extract_draw_commands.
Fix: try_system_font now ends with a last-resort Arial family fallback
(arial / arialbd / ariali / arialbi based on bold/italic hints from the
font name). Character mapping stays correct because char_to_glyph_id
already routes through the font's ToUnicode CMap → Unicode → Arial cmap →
GID. Only the visual letter shape changes.
CIDFontType2 path (the v1.48.1 fix) is untouched.
Verified with new regression test (tests/test_type1_text.rs) on both PDFs:
- AC294 (Type1 + TrueType): 0 → 711 text fills emitted
- Vloerverwarming (CIDFontType2): 2199 fills, unchanged1 parent 558e9eb commit 2f69a62
6 files changed
Lines changed: 108 additions & 13 deletions
File tree
- open-pdf-render
- src
- tests
- open-pdf-studio
- src-tauri
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
364 | 364 | | |
365 | 365 | | |
366 | 366 | | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
367 | 372 | | |
368 | 373 | | |
369 | 374 | | |
| |||
373 | 378 | | |
374 | 379 | | |
375 | 380 | | |
376 | | - | |
377 | | - | |
378 | | - | |
379 | | - | |
380 | | - | |
381 | | - | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
382 | 392 | | |
383 | | - | |
384 | | - | |
385 | | - | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
386 | 411 | | |
387 | 412 | | |
| 413 | + | |
388 | 414 | | |
389 | 415 | | |
390 | 416 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
0 commit comments