Commit ebe9ede
committed
fix(ci): explicitly bundle WebView2Loader.dll into NSIS installer (v1.47.5)
CI builds were not bundling WebView2Loader.dll because cargo build alone
does not copy it from webview2-com-sys's OUT_DIR to target/release/.
Add a Windows-only pre-bundle step that runs cargo build first, then
copies the x64 DLL from target/release/build/webview2-com-sys-*/out/x64/
to target/release/WebView2Loader.dll, where the existing NSIS template
(installer.nsi:639) picks it up via !if /FILEEXISTS.
Step fails the job if the DLL cannot be located, so silently broken
installers can no longer ship.1 parent 1e9103d commit ebe9ede
5 files changed
Lines changed: 28 additions & 4 deletions
File tree
- .github/workflows
- open-pdf-studio
- src-tauri
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
113 | 137 | | |
114 | 138 | | |
115 | 139 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
0 commit comments