Skip to content

fix(agent): adding checks for session and explicit systemd requirement (#166) #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dimfacion wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(agent): adding checks for session and explicit systemd requirement (#166) #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion installer/linux/agent-installer-service-user.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ if [ -z "${home_dir}" ]; then
fi

os=$(uname | tr '[:upper:]' '[:lower:]')
systemd_status=$(systemctl is-system-running)
systemd_status=$(systemctl is-system-running 2>/dev/null || true)
install_dir="${home_dir}/${OPENAEV_INSTALL_DIR}-${user}"
service_name="${user}-${OPENAEV_SERVICE_NAME}"
tenant_id="${OPENAEV_TENANT_ID}"
Expand All @@ -71,6 +71,7 @@ fi

if [ "$systemd_status" != "running" ] && [ "$systemd_status" != "degraded" ]; then
echo "Systemd is in unexpected state: $systemd_status. Installation is not supported."

@savacano28 savacano28 Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If systemd_status = true, the message is:
echo "Systemd is in unexpected state: $(true). Installation is not supported." (same comment as Copilot)

echo "Prerequisite: an active systemd system manager is required for service-user mode."
exit 1
else
echo "Systemd is in acceptable state: $systemd_status"
Expand Down
8 changes: 7 additions & 1 deletion installer/linux/agent-installer-session-user.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set -e

base_url=${OPENAEV_URL}
architecture=$(uname -m)
systemd_status=$(systemctl is-system-running)
systemd_status=$(systemctl is-system-running 2>/dev/null || true)

Comment on lines +6 to 7
os=$(uname | tr '[:upper:]' '[:lower:]')
install_dir="$HOME/${OPENAEV_INSTALL_DIR}"
Expand All @@ -24,6 +24,12 @@ else
echo "Systemd is in acceptable state: $systemd_status"
fi

if ! systemctl --user show-environment >/dev/null 2>&1; then
echo "Error: systemd user manager is not available in this session."
echo "Prerequisite: an active systemd user manager is required for session-user mode."
exit 1
fi

echo "Starting install script for ${os} | ${architecture}"

echo "01. Stopping existing ${session_name}..."
Expand Down
3 changes: 2 additions & 1 deletion installer/linux/agent-installer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set -e

base_url=${OPENAEV_URL}
architecture=$(uname -m)
systemd_status=$(systemctl is-system-running)
systemd_status=$(systemctl is-system-running 2>/dev/null || true)

Comment on lines +6 to 7
os=$(uname | tr '[:upper:]' '[:lower:]')
install_dir="${OPENAEV_INSTALL_DIR}"
Expand All @@ -17,6 +17,7 @@ fi

if [ "$systemd_status" != "running" ] && [ "$systemd_status" != "degraded" ]; then
echo "Systemd is in unexpected state: $systemd_status. Installation is not supported."
echo "Prerequisite: an active systemd system manager is required for service mode."
exit 1
else
echo "Systemd is in acceptable state: $systemd_status"
Expand Down
Loading