[palo-alto-cortex-xsoar] feat(collector): create XSOAR collector (#301)#348
Open
mariot wants to merge 10 commits into
Open
[palo-alto-cortex-xsoar] feat(collector): create XSOAR collector (#301)#348mariot wants to merge 10 commits into
mariot wants to merge 10 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 71.01% 77.10% +6.09%
==========================================
Files 128 165 +37
Lines 6775 8692 +1917
==========================================
+ Hits 4811 6702 +1891
- Misses 1964 1990 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6cf130c to
11e31c3
Compare
guzmud
reviewed
Apr 28, 2026
guzmud
reviewed
Apr 29, 2026
guzmud
reviewed
May 6, 2026
Member
|
Unless I'm mistaken, the API rate-limit responses leading to a backoff and retry is missing from the codebase (US.3 Error Handling & Resilience, AC-3.1, part of chunk 5 Hardening & Delivery). Edit: handled by including the HTTP error 429 in the retry/backoff system |
87fe716 to
1caf077
Compare
Kakudou
requested changes
May 11, 2026
Member
Kakudou
left a comment
There was a problem hiding this comment.
Mostly QoL, so i will conduct the execution/usage tests of the collector while waiting for those small fixes ;)
31e9405 to
715f894
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Testing Instructions
Related issues
Checklist
Further comments