fix(audit-log): remove constant agent register from audit logging (#163)

Author: Dimfacion

openaev-model/src/main/java/io/openaev/database/audit/AuditLogContext.java

@@ -1,6 +1,7 @@
 package io.openaev.database.audit;
 
 import com.fasterxml.jackson.annotation.JsonProperty;
+import java.util.Collections;
 import java.util.LinkedHashMap;
 import java.util.Map;
 import org.springframework.web.context.request.RequestAttributes;
@@ -24,17 +25,6 @@ public final class AuditLogContext {
   private static final String REQUEST_ATTR_CLEANUP_REGISTERED = "openaev.audit.cleanupRegistered";
   private static final String REQUEST_ATTR_ENABLED = "openaev.audit.enabled";
 
-  private static final ThreadLocal<Map<String, Map<String, Object>>> BEFORE_SNAPSHOTS_TL =
-      ThreadLocal.withInitial(LinkedHashMap::new);
-
-  private static final ThreadLocal<Map<String, EntitySnapshot>> SNAPSHOTS_TL =
-      ThreadLocal.withInitial(LinkedHashMap::new);
-
-  private static final ThreadLocal<Boolean> CLEANUP_REGISTERED_TL =
-      ThreadLocal.withInitial(() -> false);
-
-  private static final ThreadLocal<Boolean> ENABLED_TL = ThreadLocal.withInitial(() -> true);
-
   private AuditLogContext() {}
 
   // -- Before snapshot --
@@ -48,9 +38,7 @@ public static void setEnabled(boolean enabled) {
     if (hasRequestContext()) {
       requestAttributes()
           .setAttribute(REQUEST_ATTR_ENABLED, enabled, RequestAttributes.SCOPE_REQUEST);
-      return;
     }
-    ENABLED_TL.set(enabled);
   }
 
   /** Returns {@code true} if audit logging is enabled for the current request/thread. */
@@ -60,7 +48,7 @@ public static boolean isEnabled() {
           requestAttributes().getAttribute(REQUEST_ATTR_ENABLED, RequestAttributes.SCOPE_REQUEST);
       return val == null || Boolean.TRUE.equals(val);
     }
-    return Boolean.TRUE.equals(ENABLED_TL.get());
+    return true;
   }
 
   public static void storeBefore(String entityId, Map<String, Object> snapshot) {
@@ -92,17 +80,15 @@ public static boolean isCleanupRegistered() {
               .getAttribute(REQUEST_ATTR_CLEANUP_REGISTERED, RequestAttributes.SCOPE_REQUEST);
       return Boolean.TRUE.equals(val);
     }
-    return Boolean.TRUE.equals(CLEANUP_REGISTERED_TL.get());
+    return true;
   }
 
   public static void markCleanupRegistered() {
     if (hasRequestContext()) {
       requestAttributes()
           .setAttribute(
               REQUEST_ATTR_CLEANUP_REGISTERED, Boolean.TRUE, RequestAttributes.SCOPE_REQUEST);
-      return;
     }
-    CLEANUP_REGISTERED_TL.set(true);
   }
 
   public static void clear() {
@@ -112,11 +98,6 @@ public static void clear() {
       attrs.removeAttribute(REQUEST_ATTR_ENTITY_SNAPSHOTS, RequestAttributes.SCOPE_REQUEST);
       attrs.removeAttribute(REQUEST_ATTR_CLEANUP_REGISTERED, RequestAttributes.SCOPE_REQUEST);
       attrs.removeAttribute(REQUEST_ATTR_ENABLED, RequestAttributes.SCOPE_REQUEST);
-    } else {
-      BEFORE_SNAPSHOTS_TL.remove();
-      SNAPSHOTS_TL.remove();
-      CLEANUP_REGISTERED_TL.remove();
-      ENABLED_TL.remove();
     }
   }
 
@@ -132,10 +113,6 @@ public static void clearAfterTransactionCompletion() {
       attrs.removeAttribute(REQUEST_ATTR_BEFORE_SNAPSHOTS, RequestAttributes.SCOPE_REQUEST);
       attrs.removeAttribute(REQUEST_ATTR_CLEANUP_REGISTERED, RequestAttributes.SCOPE_REQUEST);
     }
-
-    BEFORE_SNAPSHOTS_TL.remove();
-    SNAPSHOTS_TL.remove();
-    CLEANUP_REGISTERED_TL.remove();
   }
 
   // -- Request/thread storage helpers --
@@ -153,7 +130,7 @@ private static Map<String, Map<String, Object>> beforeSnapshots() {
       attrs.setAttribute(REQUEST_ATTR_BEFORE_SNAPSHOTS, created, RequestAttributes.SCOPE_REQUEST);
       return created;
     }
-    return BEFORE_SNAPSHOTS_TL.get();
+    return Collections.emptyMap();
   }
 
   @SuppressWarnings("unchecked")
@@ -169,10 +146,10 @@ private static Map<String, EntitySnapshot> snapshots() {
       attrs.setAttribute(REQUEST_ATTR_ENTITY_SNAPSHOTS, created, RequestAttributes.SCOPE_REQUEST);
       return created;
     }
-    return SNAPSHOTS_TL.get();
+    return Collections.emptyMap();
   }
 
-  private static boolean hasRequestContext() {
+  public static boolean hasRequestContext() {
     return RequestContextHolder.getRequestAttributes() != null;
   }
 

openaev-model/src/main/java/io/openaev/database/model/Agent.java

@@ -65,6 +65,7 @@ public enum DEPLOYMENT_MODE {
   @JsonProperty("agent_asset")
   @Schema(implementation = String.class)
   @NotNull
+  @AuditStateIgnore
   private Asset asset;
 
   @Queryable(sortable = true)
@@ -145,6 +146,7 @@ public boolean isActive() {
   @Column(name = "agent_created_at")
   @JsonProperty("agent_created_at")
   @NotNull
+  @AuditStateIgnore
   private Instant createdAt = now();
 
   @AuditStateIgnore
@@ -155,6 +157,7 @@ public boolean isActive() {
 
   @Column(name = "agent_cleared_at")
   @JsonProperty("agent_cleared_at")
+  @AuditStateIgnore
   private Instant clearedAt = now();
 
   @Getter(onMethod_ = @JsonIgnore)

openaev-model/src/main/java/io/openaev/database/model/Asset.java

@@ -94,6 +94,7 @@ public void setTags(Set<Tag> tags) {
   @JsonIgnore
   @ManyToMany(mappedBy = "assets")
   @Queryable(filterable = true, dynamicValues = true, path = "assetGroups.id")
+  @AuditStateIgnore
   private Set<AssetGroup> assetGroups = new HashSet<>();
 
   // -- AUDIT --
@@ -102,6 +103,7 @@ public void setTags(Set<Tag> tags) {
   @JsonProperty("asset_created_at")
   @NotNull
   @CreationTimestamp
+  @AuditStateIgnore
   private Instant createdAt = now();
 
   @AuditStateIgnore