Skip to content

Commit 4bb7c1a

Browse files
CopilotSeb-MIGUEL
andcommitted
[backend] fix(test): use IGNORING_ARRAY_ORDER in InjectTargetSearchTest
Agent-Logs-Url: https://github.com/OpenAEV-Platform/openaev/sessions/820c827e-404d-4733-802c-dc08a72b6345 Co-authored-by: Seb-MIGUEL <203619865+Seb-MIGUEL@users.noreply.github.com>
1 parent 7c9c5d0 commit 4bb7c1a

4 files changed

Lines changed: 7 additions & 8 deletions

File tree

openaev-api/src/test/java/io/openaev/rest/inject/InjectTargetSearchTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,10 @@ public void orFilterGroupCombinationShouldNotReturnAgentThatIsNotTargetOfInject(
348348
agent3Wrapper.get().getAsset().getId(),
349349
agent3Wrapper.get().getExecutor().getType()));
350350

351-
assertThatJson(response).node("content").isEqualTo(mapper.writeValueAsString(expected));
351+
assertThatJson(response)
352+
.when(Option.IGNORING_ARRAY_ORDER)
353+
.node("content")
354+
.isEqualTo(mapper.writeValueAsString(expected));
352355
}
353356
}
354357

openaev-front/src/actions/Schema.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -361,9 +361,7 @@ export const storeHelper = state => ({
361361
getExerciseInjectExpectations: id => entities('injectexpectations', state).filter(
362362
i => i.get('inject_expectation_exercise') === id,
363363
),
364-
getInjectExpectationsByAsset: (id, type) => entities('injectexpectations', state).filter(
365-
i => (i.get('inject_expectation_asset') === id && i.get('inject_expectation_type') === type),
366-
),
364+
367365
getInjectExpectationsMap: () => maps('injectexpectations', state),
368366
// documents
369367
getDocuments: () => entities('documents', state),

openaev-front/src/actions/injects/inject-helper.d.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import {
22
type Exercise,
33
type Inject,
4-
type InjectExpectation, type InjectExpectationAgentOutput,
5-
type InjectTarget,
4+
type InjectExpectation,
65
type Scenario,
76
type Team,
87
} from '../../utils/api-types';
@@ -17,6 +16,4 @@ export interface InjectHelper {
1716

1817
getScenarioInjects: (scenarioId: Scenario['scenario_id']) => Inject[];
1918
getTeamScenarioInjects: (teamId: Team['team_id']) => Inject[];
20-
21-
getInjectExpectationsByAsset: (targetId: InjectTarget['target_id'], expectationType: string) => InjectExpectationAgentOutput[];
2219
}

openaev-front/src/admin/components/atomic_testings/atomic_testing/target_result/InjectExpectationAggregatedAgentsView.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ const InjectExpectationAggregatedAgentsView = ({ inject, expectationType, target
3737
setInjectExpectationsWithAgents(result.data ?? []);
3838
}
3939
})
40+
.catch(() => {}) // error already notified by simpleCall
4041
.finally(() => {
4142
if (active) {
4243
setLoading(false);

0 commit comments

Comments
 (0)