Skip to content

Commit 9ca5057

Browse files
committed
chore(agents): improv AI files
1 parent 54d9439 commit 9ca5057

4 files changed

Lines changed: 9 additions & 10 deletions

File tree

.github/agents/api-reviewer.agent.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,8 @@ If the PR changes Output DTO fields, flag for frontend type regeneration:
122122

123123
## What NOT to Flag
124124

125-
- `@JsonIgnore` on `tenant` relation → correct, prevents circular reference and data exposure
126-
- `skipRBAC = true` with an explanatory comment → intentional bypass, not missing `@AccessControl`
125+
In addition to **Shared Exceptions** in `AGENTS.md`:
126+
127127
- Legacy controllers in `io.openaev.rest` that are NOT modified in this PR → migration is incremental
128128
- Output DTOs including `id` field → standard, required for client-side referencing
129129
- `@Transactional` on controller methods that coordinate multiple service calls → acceptable pattern

.github/agents/frontend-reviewer.agent.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ These thresholds trigger automatic severity levels regardless of subjective asse
5050

5151
## What NOT to Flag
5252

53+
In addition to **Shared Exceptions** in `AGENTS.md`:
54+
5355
- Legacy `.jsx` files that are NOT being touched in this PR — migration is incremental
5456
- `makeStyles` in files not modified by this PR — only flag when the file is being changed
5557
- Redux store usage in existing features — only flag for new features

.github/agents/multi-tenancy-reviewer.agent.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,15 +93,11 @@ For tenant-scoped tables:
9393

9494
## What NOT to Flag
9595

96-
- Platform-level entities (`Tenant`) without `@Filter` → correct by design
97-
- Dual-scope entities (Settings, User, Role, Group) without `@Filter` → correct by design, scope enforced by services
98-
- `TenantContext.getCurrentTenant()` used in **legacy `io.openaev.rest` controllers** to pass tenant as argument to services → acceptable (legacy), but new code must use `TENANT_PREFIX` + `@PathVariable`
96+
In addition to **Shared Exceptions** in `AGENTS.md`:
97+
9998
- `@PathVariable String tenantId` in new `io.openaev.api` controllers → this is the correct pattern
10099
- Service receiving `tenantId` as a method parameter (not calling `TenantContext` directly) → correct
101-
- Migration using default tenant UUID `2cffad3a-0001-4078-b0e2-ef74274022c3` → standard seed data
102-
- Test fixtures setting tenant context explicitly → test-only setup
103-
- `@JsonIgnore` already present on tenant relation → already handled
104-
- `FetchType.EAGER` on `capabilities` / `permissions` collections → intentional for RBAC performance, not a tenant issue
100+
- Test fixtures setting tenant context explicitly → test-only setup (distinct from hardcoded credentials)
105101

106102
## Output Format
107103

.github/agents/performance-reviewer.agent.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ Escalate to **Opus 4.6** for reviews involving complex query optimization or arc
4545

4646
## What NOT to Flag
4747

48-
- `FetchType.EAGER` on `capabilities` / `permissions` collections → small, always-needed for RBAC (intentional exception, documented in `security.instructions.md`)
48+
In addition to **Shared Exceptions** in `AGENTS.md`:
49+
4950
- `findAll()` on reference data tables (enum-like, <50 rows) — e.g. `ResourceType`, `Capability`
5051
- In-memory filtering on collections already fetched for other reasons
5152
- Test code performance — only flag production code

0 commit comments

Comments
 (0)