[frontend/backend] fix: add pagination on list widget (#4410)#4955
Merged
Conversation
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
MarineLeM
changed the title
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/current #4955 +/- ##
=====================================================
+ Coverage 56.54% 56.66% +0.11%
- Complexity 4472 4582 +110
=====================================================
Files 991 1002 +11
Lines 29665 30396 +731
Branches 2167 2248 +81
=====================================================
+ Hits 16775 17224 +449
- Misses 11932 12206 +274
- Partials 958 966 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }, [widgetId, filterValues]); | ||
|
|
||
| useEffect(() => { | ||
| if (!customDashboard || !widgetId || filterValues == null || !seriesIndex) { |
Member
There was a problem hiding this comment.
Niptick: !seriesIndex treats 0 as falsy. Using seriesIndex == null avoids that if 0 is valid
Signed-off-by: Marine LM <marine.lemezo@filigran.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Testing Instructions
Verify if the scenario and simulation dashboard does not have any regression
Related issues