Skip to content

[backend] fix: add orphanRomoval parameter for Scenarion/inject relat…#4968

Merged
heditar merged 21 commits into
release/currentfrom
fix/bug-scenario-deletion
Mar 19, 2026
Merged

[backend] fix: add orphanRomoval parameter for Scenarion/inject relat…#4968
heditar merged 21 commits into
release/currentfrom
fix/bug-scenario-deletion

Conversation

@heditar
Copy link
Copy Markdown
Contributor

@heditar heditar commented Feb 17, 2026

Proposed changes

  • Spring upgrade created a bug that was throwing an error while trying to delete a scenario/simulation. This PR fix this issue by adding cascade = CascadeType.REMOVE to the relationship

Testing Instructions

  1. Create a scenario/simulation, add an inject, delete ii -> it should succeed

Related issues

  • Closes #5

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • [NA] I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.50%. Comparing base (7e088a9) to head (a16f947).
⚠️ Report is 1 commits behind head on release/current.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/current    #4968   +/-   ##
==================================================
  Coverage              59.49%   59.50%           
- Complexity              5091     5094    +3     
==================================================
  Files                   1039     1039           
  Lines                  31740    31740           
  Branches                2372     2372           
==================================================
+ Hits                   18885    18888    +3     
  Misses                 11796    11796           
+ Partials                1059     1056    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@heditar heditar marked this pull request as ready for review March 13, 2026 11:45
Copy link
Copy Markdown
Member

@GaetanSantucci GaetanSantucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test ok, corresponds to the expected behavior

@heditar heditar merged commit a38f953 into release/current Mar 19, 2026
12 of 13 checks passed
@heditar heditar deleted the fix/bug-scenario-deletion branch March 19, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants