[backend] feat(multi-tenancy): add tenant thanks to sso configuration (#4864)#5565
Closed
RomuDeuxfois wants to merge 9 commits intorelease/currentfrom
Closed
[backend] feat(multi-tenancy): add tenant thanks to sso configuration (#4864)#5565RomuDeuxfois wants to merge 9 commits intorelease/currentfrom
RomuDeuxfois wants to merge 9 commits intorelease/currentfrom
Conversation
github-actions
Bot
added
the
filigran team
Member
|
Seems to be working but there are issues with the CI and I have questions that I transmitted to the product team |
RomuDeuxfois
force-pushed
the
issue/sso-attach-tenant
branch
2 times, most recently
from
53a354c to
81aa4e5
Compare
|
Thank you for your contribution. This PR is but one step away from being ready for merging: all commits must be PGP-signed. To get started, please see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
RomuDeuxfois
force-pushed
the
issue/sso-attach-tenant
branch
2 times, most recently
from
3e4871b to
83d96e5
Compare
… on groups (#4864) fix(ci): keep SecurityServiceTest unchanged (no groups_management dependency) SecurityServiceTest only reads tenant_id (simple string) from application.properties — not the JSON blob. No change needed here. fix(ci): load groups_management from JSON file in UserMappingServiceTest Replace env.getProperty() calls with file-based loading to break the CodeQL taint tracking chain that caused infinite analysis. fix(ci): remove inline JSON from test application.properties The groups_management JSON is now loaded from a dedicated file (groups-management-test.json) to avoid CodeQL taint tracking issues. fix(ci): extract groups_management JSON to dedicated test file Move inline JSON from application.properties to a dedicated JSON file to prevent CodeQL taint tracking from hanging on the env.getProperty() → ObjectMapper.readValue() → findById() data flow.
RomuDeuxfois
force-pushed
the
issue/sso-attach-tenant
branch
2 times, most recently
from
a464245 to
4632c40
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #5565 +/- ##
=====================================================
+ Coverage 40.68% 41.06% +0.38%
- Complexity 5913 6012 +99
=====================================================
Files 2092 2107 +15
Lines 55323 56132 +809
Branches 6932 7017 +85
=====================================================
+ Hits 22506 23053 +547
- Misses 31494 31739 +245
- Partials 1323 1340 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RomuDeuxfois
force-pushed
the
issue/sso-attach-tenant
branch
2 times, most recently
from
b81bf55 to
0b305de
Compare
RomuDeuxfois
force-pushed
the
issue/sso-attach-tenant
branch
from
0b305de to
b50f447
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues