Skip to content

[frontend] fix(inject): avoid DOM pollution between inject targets (#5080)#5634

Merged
antoinemzs merged 1 commit into
masterfrom
5080/dom_pollution
Apr 30, 2026
Merged

[frontend] fix(inject): avoid DOM pollution between inject targets (#5080)#5634
antoinemzs merged 1 commit into
masterfrom
5080/dom_pollution

Conversation

@antoinemzs
Copy link
Copy Markdown
Member

Proposed changes

  • Introduce inject filter to store query for iject expectation results

Testing Instructions

  1. Create scenario with multiple payload injects (e.g. 3) and assign a single endpoint to each inject
  2. Run multiple simulations of that scenario
  3. Manually assign results to each Detection, Prevention expectations on each inject for the endpoint
  4. In a given simulation: in targets, navigate down to the agent, display the Detection tab
  5. Navigate to another inject, same agent target, display the Detection tab
  6. It only shows the results for the Detection expectation of the current inject, not from any other

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality

Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 37.17%. Comparing base (280d53e) to head (8e7a987).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...t_result/InjectExpectationAggregatedAgentsView.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5634      +/-   ##
============================================
- Coverage     37.18%   37.17%   -0.01%     
- Complexity     4922     4923       +1     
============================================
  Files          1879     1879              
  Lines         49395    49395              
  Branches       6138     6136       -2     
============================================
- Hits          18368    18365       -3     
+ Misses        29937    29935       -2     
- Partials       1090     1095       +5     
Flag Coverage Δ
backend 59.08% <ø> (+<0.01%) ⬆️
e2e 24.89% <ø> (ø)
frontend 0.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antoinemzs antoinemzs merged commit ac759fb into master Apr 30, 2026
31 checks passed
@antoinemzs antoinemzs deleted the 5080/dom_pollution branch April 30, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detection/Prevention results from a different test

2 participants